Mention the new % unit for maxBytes and maxPhysicalBytes in Memory management documentation#8461
Merged
saudet merged 1 commit intodeeplearning4j:masterfrom Dec 5, 2019
magnolia-cms:percentage-unit-for-max-bytes-and-physical-bytes
Merged
Mention the new % unit for maxBytes and maxPhysicalBytes in Memory management documentation#8461saudet merged 1 commit intodeeplearning4j:masterfrom magnolia-cms:percentage-unit-for-max-bytes-and-physical-bytes
saudet merged 1 commit intodeeplearning4j:masterfrom
magnolia-cms:percentage-unit-for-max-bytes-and-physical-bytes
Conversation
saudet
suggested changes
Nov 29, 2019
Contributor
saudet
left a comment
There was a problem hiding this comment.
To simplify the mental model, sizes specified with % are relative to maxMemory for both maxBytes and maxPhysicalBytes.
…nagement documentation (#8435) Signed-off-by: Maxime Michel <maxime.michel@magnolia-cms.com>
saudet
approved these changes
Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Documentation update of the enhancement suggested in #8435 and tackled in bytedeco/javacpp#365.
Quick checklist
The following checklist helps ensure your PR is complete: