Conversation
Created a PR template to enforce best practises when developers and implementers open PRs in the code. They will be prompted to fill in details about their work and provide clear descriptions and details. This forms part of the SDLC.
Added a Github workflow to build the code and run the automated tests and to pass test coverage information to Code Climate. Another workflow will be added later to manage building the code, and running integration tests for pushes to master, or releases.
Author
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test a Github Actions CI workflow to build the code and run the automated tests and checks (from Code Climate and SYNK).
Add the PR template to enforce the structure of PR messages.
Type of change
Testing
Test Cases
mvn clean installand view jacoco test coverageDeployment Instructions (optional)
These instructions explain how to set up the integrations for Code Climate and Synk. They only need to be done once per repo.
The Code Climate dashboard can be viewed without an account, but to get access to the Synk dashboard you will need to be added as a member of the organisation.
All integrations require approval by a Github organisation admin - so a higher authority than repo admin.
For Code Climate:
CC_TEST_REPORTER_IDFor Snyk:
SNYK_TOKENQA Instructions (optional)
See the Code Climate dashboards:
To access the Synk dashboards, you will need to be added as a member of the organisation
Breaking Changes
Dependencies
Related Tickets & Documents
Part of deliverable 1.4.1
Screenshots/Recordings
TODO
Checklist
Additional Notes