chore(tests): delete mocked github/list-user-orgs.test.ts#3501
Merged
viktormarinho merged 1 commit intoMay 27, 2026
Merged
Conversation
596 lines of vi.mock-driven tests for GITHUB_LIST_USER_ORGS — stubs refreshAccessToken, mocks global.fetch, fakes BoundAuthClient. Per the migration plan: "if we have a recorded fixture; otherwise delete (don't keep mocked fetch tests)". We don't have a recorded GitHub fixture, and writing one would require a real GitHub OAuth flow in tests — not feasible. The tool itself is exercised through real GitHub calls in development. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
🧪 BenchmarkShould we run the Virtual MCP strategy benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsSuggested: Patch ( React with an emoji to override the release type:
Current version:
|
tlgimenes
added a commit
that referenced
this pull request
May 30, 2026
Resolve conflicts in the GitHub App-scope consumer refactor against main: - github-clone-info.ts: keep bot-identity buildCloneInfo (no /user call); merge main's token-baking + sandbox-lifecycle docstring and keep main's new buildAnonymousCloneInfo for public-repo clones. - list-user-orgs.ts: keep the /installation/repositories refactor and adopt main's "delete cached token only on definitive invalid_grant" behavior (drop explicit tokenStorage.delete on 401; delegate to refreshAndStore). - Delete mocked-fetch tests list-user-orgs.test.ts (modify/delete: honor main's deliberate removal in #3501) and github-clone-info.test.ts (same mock.module + global.fetch pattern), per main's policy of not keeping mocked GitHub fetch tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
596 lines of `vi.mock` / `mock.module` -driven tests for `GITHUB_LIST_USER_ORGS` — stubs the OAuth refresh helper, mocks `global.fetch` for GitHub API responses, fakes `BoundAuthClient`.
Per the migration plan: "if we have a recorded fixture; otherwise delete (don't keep mocked fetch tests)". We don't have a recorded GitHub fixture, and writing one would require a real GitHub OAuth flow inside CI — not feasible. The tool itself is exercised through real GitHub in development.
This row is just a deletion — no Playwright replacement.
🤖 Generated with Claude Code
Summary by cubic
Removed the mocked test
apps/mesh/src/tools/github/list-user-orgs.test.ts(596 lines) forGITHUB_LIST_USER_ORGSper the test migration plan. No recorded GitHub fixture exists, so we’re dropping brittlevi.mock/global.fetchtests; no functional code changes.Written for commit 936cf93. Summary will update on new commits. Review in cubic