[Feature][Metric] Custom SQL support export error data#586
Merged
Conversation
- Replace direct ACTUAL_AGGREGATE_SQL access with SqlMetric.getTableDiscoverySql in custom SQL table extraction across engines - Update rewritten SQL through SqlMetric.setTableDiscoverySql - Add getTableDiscoverySql and setTableDiscoverySql implementations for CustomCountSql - Use SqlMetric table discovery SQL in JobServiceImpl when resolving metadata - Centralize table discovery SQL handling to improve extensibility and maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Summary
This PR adds a new
custom_count_sqlmetric that allows users to define custom SQL for invalid/error data extraction and automatically calculates the invalid row count from that SQL.It also refactors custom SQL table discovery so metric plugins can define which SQL field should be used for metadata/table extraction, instead of hard-coding
actual_aggregate_sql.Changes
custom_count_sqlmetric plugin.META-INF/services.invalidate_items_sqlas a metric configuration key.TextArea.invalidate_items_sql.SqlMetric#getTableDiscoverySqlandSqlMetric#setTableDiscoverySql.JobServiceImplto resolve metadata using the metric-provided table discovery SQL.CustomCountSql:invalidate_items_sql${invalidate_items_table}for normal engine flowclose #560
Check list