migration2clarin7/license-dropdown-missing-labels#163
Closed
milanmajchrak wants to merge 10 commits intodtq-devfrom
Closed
migration2clarin7/license-dropdown-missing-labels#163milanmajchrak wants to merge 10 commits intodtq-devfrom
milanmajchrak wants to merge 10 commits intodtq-devfrom
Conversation
added 7 commits
April 25, 2023 11:05
…ector data into it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Check the issue.
Problems:
selectwithoptioncannot have an image: https://stackoverflow.com/questions/32068127/angular-select-with-images and there is missing searching feature, so I replaced theselectwithng-selectng-select, it was because the initial value must benullfor thengModelmapped intong-select.node_moduleswithyarn.lockand run commandyarn install. It helps you to discover dependency error which you probably will discover by the Github action what is very time consuming discovery. That is the reason why I was forced to removeng-selectfrom the DSpace project, because that lovely module destroyed whole project, I was trying to make the dependencies compatible but without any success.ng-selectI was trying to find any 3rd party module which won't destroy whole project but without any success, so I decided to create our own a new license selector, which I developed here: migration2clarin7/license-dropdown-missing-labels-2 #164