Skip to content

migration2clarin7/license-dropdown-missing-labels#163

Closed
milanmajchrak wants to merge 10 commits intodtq-devfrom
migration2clarin7/license-dropdown-missing-labels
Closed

migration2clarin7/license-dropdown-missing-labels#163
milanmajchrak wants to merge 10 commits intodtq-devfrom
migration2clarin7/license-dropdown-missing-labels

Conversation

@milanmajchrak
Copy link
Copy Markdown
Collaborator

@milanmajchrak milanmajchrak commented Apr 24, 2023

Phases MP MM MB MR JM Total
ETA 0 1.2 0 0 0 0
Developing 0 2.5+8+1.5+8 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

Check the issue.

Problems:

  • html tags select with option cannot have an image: https://stackoverflow.com/questions/32068127/angular-select-with-images and there is missing searching feature, so I replaced the select with ng-select
  • placeholder wasn't working in the ng-select, it was because the initial value must be null for the ngModel mapped into ng-select.
  • NOTE: everytime after installing 3rd-party framework into DSpace try to remove all node_modules with yarn.lock and run command yarn install. It helps you to discover dependency error which you probably will discover by the Github action what is very time consuming discovery. That is the reason why I was forced to remove ng-select from the DSpace project, because that lovely module destroyed whole project, I was trying to make the dependencies compatible but without any success.
  • After disaster with ng-select I was trying to find any 3rd party module which won't destroy whole project but without any success, so I decided to create our own a new license selector, which I developed here: migration2clarin7/license-dropdown-missing-labels-2 #164

@milanmajchrak milanmajchrak linked an issue Apr 24, 2023 that may be closed by this pull request
@milanmajchrak milanmajchrak self-assigned this Apr 24, 2023
@milanmajchrak milanmajchrak changed the title Find out that option cannot have an image. migration2clarin7/license-dropdown-missing-labels Apr 26, 2023
@vidiecan vidiecan deleted the migration2clarin7/license-dropdown-missing-labels branch October 21, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

71-FE/license-dropdown-missing-labels

1 participant