Merged
Conversation
…ethod `showSubmitter` was still called.
milanmajchrak
added a commit
that referenced
this pull request
Jun 19, 2024
* Initial commit * Fixed problem with reloading the item version. Problem was that the method `showSubmitter` was still called. * Fixed lint issue Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
There is bug in the versions table: the table is still reloading so the user has a problem to redirect for the another version.
Problem: The method
showSubmitterwas still called.Solution: The method is called only once and the return value is stored into the variable
showSubmitter$