Skip to content

Bugfix - remove hardcoded n_fields from prairie_view_loader.py #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttngu207 merged 1 commit into from
Feb 16, 2024
Merged

Bugfix - remove hardcoded n_fields from prairie_view_loader.py #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Observes [Semantic Versioning](https://semver.org/spec/v2.0.0.html) standard and

+ Add - multi-plane `caiman_loader.py` to process multi-plane tiffs
+ Update - DANDI upload utility
+ Fix - `n_fields` == 1 -> `n_fields` == `n_depths` in `prairie_view_loader.py`

## [0.6.1] - 2023-08-02

Expand Down
3 changes: 1 addition & 2 deletions element_interface/prairie_view_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ def _extract_prairieview_metadata(xml_filepath: str):

bidirectional_scan = False # Does not support bidirectional
roi = 0
n_fields = 1 # Always contains 1 field
recording_start_time = xml_root.find(".//Sequence/[@cycle='1']").attrib.get("time")

# Get all channels and find unique values
Expand Down Expand Up @@ -288,7 +287,7 @@ def _extract_prairieview_metadata(xml_filepath: str):
), "Number of z fields does not match number of depths."

metainfo = dict(
num_fields=n_fields,
num_fields=n_depths,
num_channels=n_channels,
num_planes=n_depths,
num_frames=n_frames,
Expand Down