[CP-4785] Add support for Python 3.12 #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39d3631 to
e09b09b
Compare
BogdanFloris
approved these changes
Apr 30, 2025
| def get_part(name, key, highlight): | ||
| if isinstance(key, str): | ||
| slice_val = ast.Str(s=key) | ||
| slice_val = ast.Constant(value=key) |
Contributor
There was a problem hiding this comment.
Is this a change in the ast library in python3.12?
Contributor
Author
There was a problem hiding this comment.
It's 2 different deprecations:
DeprecationWarning: ast.Str is deprecated and will be removed in Python 3.14; use ast.Constant instead
slice_val = ast.Str(s=key)
DeprecationWarning: Attribute s is deprecated and will be removed in Python 3.14; use value instead
return Constant(*args, **kwargs)
Not strictly mandatory for this work, but at least it's less work for next time (and fewer deprecation warnings making noise).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datacamp.atlassian.net/browse/CP-4785
Blocked by datacamp/protowhat#63
random.randint