Skip to content

Fix namespace validation logic #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicklan merged 2 commits into from
Aug 28, 2025
Merged

Fix namespace validation logic #231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3afb4c
fix namespace validation logic
madeline-shao-db Aug 27, 2025
9dd8e91
unit test
madeline-shao-db Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion src/env.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ impl Env {
}
label
.chars()
.all(|c| (c.is_ascii_lowercase() && c.is_ascii_alphanumeric()) || c == '-')
.all(|c| (c.is_ascii_lowercase() || c.is_ascii_digit()) || c == '-')
&& label.chars().next().unwrap().is_ascii_alphanumeric()
&& label.chars().last().unwrap().is_ascii_alphanumeric()
}
Expand Down Expand Up @@ -637,4 +637,32 @@ mod tests {
assert_eq!(exp4.expansion, None);
assert_eq!(exp4.rest, "x");
}

#[test]
fn test_validate_rfc_1123_label() {
// Valid cases
assert!(Env::validate_rfc_1123_label("valid"));
assert!(Env::validate_rfc_1123_label("valid-name"));
assert!(Env::validate_rfc_1123_label("valid-123"));
assert!(Env::validate_rfc_1123_label("123-valid"));
assert!(Env::validate_rfc_1123_label("a"));
assert!(Env::validate_rfc_1123_label("1"));
assert!(Env::validate_rfc_1123_label("abc-123-def"));

// Invalid cases - empty or too long
assert!(!Env::validate_rfc_1123_label(""));
assert!(!Env::validate_rfc_1123_label(&"a".repeat(64))); // Max length is 63

// Invalid cases - starts or ends with hyphen
assert!(!Env::validate_rfc_1123_label("-invalid"));
assert!(!Env::validate_rfc_1123_label("invalid-"));
assert!(!Env::validate_rfc_1123_label("-"));

// Invalid cases - contains uppercase or invalid characters
assert!(!Env::validate_rfc_1123_label("Invalid"));
assert!(!Env::validate_rfc_1123_label("invalid_name"));
assert!(!Env::validate_rfc_1123_label("invalid.name"));
assert!(!Env::validate_rfc_1123_label("invalid@name"));
assert!(!Env::validate_rfc_1123_label("invalid name"));
}
}
Loading