Add IDE flag and support for IDE integration for vscode and cursor #4452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilia-db
commented
Feb 5, 2026
| return ideCmd.Run() | ||
| } | ||
|
|
||
| func getSSHConfigPath() (string, error) { |
Contributor
Author
There was a problem hiding this comment.
This is the next function are replaced by a better logic in the follow up PR: #4453
Collaborator
|
Commit: b5cc387
19 interesting tests: 7 KNOWN, 5 SKIP, 5 RECOVERED, 2 flaky
Top 50 slowest tests (at least 2 minutes):
|
anton-107
reviewed
Feb 6, 2026
|
|
||
| func runIDE(ctx context.Context, client *databricks.WorkspaceClient, userName, keyPath string, serverPort int, clusterID string, opts ClientOptions) error { | ||
| // Validate IDE value | ||
| if opts.IDE != "vscode" && opts.IDE != "cursor" { |
Contributor
There was a problem hiding this comment.
shall we define constants for "vscode" and "cursor"?
anton-107
approved these changes
Feb 6, 2026
947c492 to
b5cc387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add --ide = cursor/vscode flag to the
ssh connectcommandBased on #4162
Why
Tests