-
Notifications
You must be signed in to change notification settings - Fork 141
Use FUSE for bundle commands on serverless #4450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+227
−9
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,10 @@ | ||
| package dbr | ||
|
|
||
| import "context" | ||
| import ( | ||
| "context" | ||
| "strconv" | ||
| "strings" | ||
| ) | ||
|
|
||
| // key is a package-local type to use for context keys. | ||
| // | ||
|
|
@@ -15,6 +19,71 @@ const ( | |
| dbrKey = key(1) | ||
| ) | ||
|
|
||
| // ClusterType represents the type of Databricks cluster. | ||
| type ClusterType int | ||
|
|
||
| const ( | ||
| ClusterTypeUnknown ClusterType = iota | ||
| ClusterTypeInteractive | ||
| ClusterTypeServerless | ||
| ) | ||
|
|
||
| func (t ClusterType) String() string { | ||
| switch t { | ||
| case ClusterTypeInteractive: | ||
| return "interactive" | ||
| case ClusterTypeServerless: | ||
| return "serverless" | ||
| default: | ||
| return "unknown" | ||
| } | ||
| } | ||
|
|
||
| // Version represents a parsed DBR version. | ||
| type Version struct { | ||
| Type ClusterType | ||
| Major int | ||
| Minor int | ||
| Raw string | ||
| } | ||
|
|
||
| // ParseVersion parses a DBR version string and returns structured version info. | ||
| // Examples: | ||
| // - "16.3" -> Interactive, Major=16, Minor=3 | ||
| // - "client.4.9" -> Serverless, Major=4, Minor=9 | ||
| func ParseVersion(version string) Version { | ||
| result := Version{Raw: version} | ||
|
|
||
| if version == "" { | ||
| return result | ||
| } | ||
|
|
||
| // Serverless versions have "client." prefix | ||
| if strings.HasPrefix(version, "client.") { | ||
| result.Type = ClusterTypeServerless | ||
| // Parse "client.X.Y" format | ||
| parts := strings.Split(strings.TrimPrefix(version, "client."), ".") | ||
| if len(parts) >= 1 { | ||
| result.Major, _ = strconv.Atoi(parts[0]) | ||
| } | ||
| if len(parts) >= 2 { | ||
| result.Minor, _ = strconv.Atoi(parts[1]) | ||
| } | ||
| return result | ||
| } | ||
|
|
||
| // Interactive versions are "X.Y" format | ||
| result.Type = ClusterTypeInteractive | ||
| parts := strings.Split(version, ".") | ||
| if len(parts) >= 1 { | ||
| result.Major, _ = strconv.Atoi(parts[0]) | ||
| } | ||
| if len(parts) >= 2 { | ||
| result.Minor, _ = strconv.Atoi(parts[1]) | ||
| } | ||
| return result | ||
| } | ||
|
|
||
| type Environment struct { | ||
| IsDbr bool | ||
| Version string | ||
|
|
@@ -61,3 +130,9 @@ func RuntimeVersion(ctx context.Context) string { | |
|
|
||
| return v.(Environment).Version | ||
| } | ||
|
|
||
| // GetVersion returns the parsed runtime version from the context. | ||
| // It expects a context returned by [DetectRuntime] or [MockRuntime]. | ||
| func GetVersion(ctx context.Context) Version { | ||
| return ParseVersion(RuntimeVersion(ctx)) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't |
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q - does this also impact Dabs-in-ws?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary to make the
bundle generate --bindcommand work. Right now DABs in ws mixes the API and FUSE. This PR makes that consistent.