-
Notifications
You must be signed in to change notification settings - Fork 143
acc: Separate test output for direct and terraform for interactive_single_user test #3768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pietern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment about this test:
We have the dynamic_version property for artifacts that forces the upgrade. If this is not used, and we observe a code change (perhaps mtime), should we start warning the user? Not sure if this is easy or not.
30 failing tests:
|
|
@pietern I'd actually make it easier and warn customers if they use the wheels with interactive clusters and don't use the dynamic version option, and recommend that they use it. But will make it separate from this PR anyway |
Changes
Separate test output for direct and terraform for interactive_single_user test
Why
TF test behaviour for wheel jobs on single-user interactive clusters is technically incorrect because TF in such a setup produces permanent drift (incorrect), which leads to cluster restart on each bundle deploy, and therefore wheel changes are picked up
Direct does not update/restart the cluster on subsequent deploys (correct), and changes for the wheel are not picked, which is expected.
I separated the test output into 2 separate files for now, to unlock the test.
Tests
Existing tests pass