refactor: use watch channel for communication between core and replication task #1541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation task Replace unbounded MPSC channel with watch channel for broadcasting committed log id to replication tasks. This simplifies the replication event handling by using an EventWatcher that monitors both entries and committed updates. Changes: - Add `EventWatcher` to receive events from entries and committed watch channels - Rename `Replicate` to `Data` for log entries replication data - Add `committed_tx`/`committed_rx` watch channel pair in `RaftCore` - Use `send_if_greater()` for committed log id updates - Remove per-replication MPSC sender in favor of shared watch channel
xp-trumpet
approved these changes
Dec 5, 2025
Collaborator
xp-trumpet
left a comment
There was a problem hiding this comment.
@xp-trumpet reviewed 12 of 12 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @drmingdrmer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
refactor: use watch channel for communication between core and replication task
Replace unbounded MPSC channel with watch channel for broadcasting
committed log id to replication tasks. This simplifies the replication
event handling by using an EventWatcher that monitors both entries and
committed updates.
Changes:
EventWatcherto receive events from entries and committed watch channelsReplicatetoDatafor log entries replication datacommitted_tx/committed_rxwatch channel pair inRaftCoresend_if_greater()for committed log id updatesThis change is