[PLUGIN-1812] Added fix for date datatype in oracle sink#516
Merged
vikasrathee-cs merged 1 commit intodata-integrations:developfrom Oct 23, 2024
Merged
Conversation
a99f062 to
918759d
Compare
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSourceDBRecord.java
Outdated
Show resolved
Hide resolved
918759d to
cbaf779
Compare
Added fix for date datatype
cbaf779 to
ca328a2
Compare
itsankit-google
previously requested changes
Oct 22, 2024
Contributor
itsankit-google
left a comment
There was a problem hiding this comment.
Please add a jira with the description.
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSourceDBRecord.java
Show resolved
Hide resolved
Contributor
|
The JIRA contains almost no description like when can the issue occur, how was it identified and what change caused it? |
Added more details to JIRA ticket.
itsankit-google
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fix for date datatype in oracle sink. Added handling for logical type Date.
https://cdap.atlassian.net/browse/PLUGIN-1812