Ensure all Expr instance can be pickled (not cloudpickle)#810
Closed
fjetter wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#331 added a check to
assert_eqthat would ensure that all expressions are serializable. There was some funny business going on, see #323There was already a debate about this in teh PR over there #331 (comment) where the main reason for allowing cloudpickle was the use of lamdbas in the test base. This PR actually fixes all of those occurences and enables pickle by default. There was just one edge case of an Expr that would require cloudpickle but I would like that this stays this way.
The cost for this check would be to not be allowed to use lambdas when writing tests that involve
assert_eq. Are we fine with this?