Fix: Required rotated chain lock sig at h - 0 not present for masternode diff block hash

[QuantumExplorer]

Summary by CodeRabbit

• New Features
  • Introduced a new verification mechanism for quorum entries, enhancing overall system reliability.
• Bug Fixes
  • Improved the handling of digital signatures by adding fallback checks to ensure smoother processing and reduce potential data validation errors.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This change adds a public method known_qualified_quorum_entry to the MasternodeListEngine to search for a matching quorum entry. Additionally, the feed_qr_info method has been updated to store signature results in intermediate variables, checking for their presence before use. The method for constructing qualified_last_commitment_per_index now first uses the new lookup method and falls back to the previous signature extraction logic if no matching entry is found.

Changes

Files

Change Summary

dash/src/sml/masternode_list_engine/mod.rs

- Added known_qualified_quorum_entry method to retrieve a QualifiedQuorumEntry based on matching quorum_hash and llmq_type. - Updated feed_qr_info to store signature results in temporary variables (maybe_sigm2, maybe_sigm1, maybe_sigm0), verifying their presence before constructing the array of signatures. - Modified the logic for constructing qualified_last_commitment_per_index to use the new method first and fall back to the previous logic if necessary.

Sequence Diagram(s)

sequenceDiagram
    participant FE as feed_qr_info
    participant ML as MasternodeListEngine
    participant QE as QuorumEntry Store

    FE->>ML: Call known_qualified_quorum_entry(quorum_entry)
    alt Entry Found
        ML-->>FE: Return QualifiedQuorumEntry
        FE->>FE: Use returned entry for qualified_last_commitment_per_index
    else Entry Not Found
        ML-->>FE: Return None
        FE->>FE: Retrieve maybe_sigm2, maybe_sigm1, maybe_sigm0
        FE->>FE: Validate and apply signatures via apply_diff for tip block
    end

Loading

Poem

Oh, what a leap in our code today,
With new checks that lead the proper way,
A method to find a quorum so neat,
Fallback paths ensuring no signature's beat.
Hoppin’ through bugs with a joyful sway,
I, a rabbit, cheer the improvements we convey!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a8b5d0b and b6e765b.

📒 Files selected for processing (1)

• dash/src/sml/masternode_list_engine/mod.rs (3 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.