Skip to content

chore: remove unified sdk references#302

Merged
xdustinface merged 1 commit intov0.42-devfrom
chore/remove-unified-sdk
Feb 26, 2026
Merged

chore: remove unified sdk references#302
xdustinface merged 1 commit intov0.42-devfrom
chore/remove-unified-sdk

Conversation

@xdustinface
Copy link
Collaborator

@xdustinface xdustinface commented Dec 22, 2025

Drop UNIFIED_SDK.md and references to it.

Summary by CodeRabbit

  • Documentation
    • Removed Unified SDK integration documentation, build guidance, and related references from README and project documentation files.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26e7bc4 and 2a27acb.

📒 Files selected for processing (5)
  • README.md
  • UNIFIED_SDK.md
  • dash-spv-ffi/CLAUDE.md
  • dash-spv-ffi/README.md
  • key-wallet-ffi/README.md
💤 Files with no reviewable changes (5)
  • dash-spv-ffi/CLAUDE.md
  • key-wallet-ffi/README.md
  • UNIFIED_SDK.md
  • README.md
  • dash-spv-ffi/README.md

📝 Walkthrough

Walkthrough

Removes all references and documentation related to the Unified SDK integration from the project. This includes deleting the dedicated UNIFIED_SDK.md documentation file and removing Unified SDK build instructions, recommendations, and notes from various README files across multiple directories.

Changes

Cohort / File(s) Summary
Unified SDK Documentation Removal
README.md, UNIFIED_SDK.md
Deleted dedicated UNIFIED_SDK.md file (90 lines) and removed 2 references to Unified SDK from the main README, including removal from the "Supports" list and "Component Documentation" section.
FFI Package Documentation Updates
dash-spv-ffi/CLAUDE.md, dash-spv-ffi/README.md, key-wallet-ffi/README.md
Removed Unified SDK build guidance sections, recommendations for iOS integration via Unified SDK, and associated bash workflow instructions from multiple package documentation files (17, 13, and 13 lines respectively).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Out with the SDK, so unified and grand,
Documentation cleaned with a wave of the hand,
Build scripts and notes take their final bow,
The project moves forward, streamlined and how! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove unified sdk references' accurately and concisely summarizes the main change: removing Unified SDK documentation and references across multiple files in the repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-unified-sdk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ZocoLini
ZocoLini previously approved these changes Dec 22, 2025
@xdustinface xdustinface marked this pull request as draft December 22, 2025 18:05
@xdustinface xdustinface changed the base branch from v0.41-dev to v0.42-dev December 30, 2025 22:35
@xdustinface xdustinface dismissed ZocoLini’s stale review December 30, 2025 22:35

The base branch was changed.

@xdustinface xdustinface marked this pull request as ready for review February 25, 2026 02:37
@xdustinface xdustinface reopened this Feb 25, 2026
@xdustinface xdustinface requested a review from ZocoLini February 25, 2026 02:41
```

**Important**: The unified SDK build process (`build_ios.sh`) merges dash-spv-ffi with platform SDK. You MUST build dash-spv-ffi first or changes won't be included!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about removing the build-ios.sh script??

Copy link
Collaborator Author

@xdustinface xdustinface Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense, will drop it in #296 or a separate PR.

@xdustinface xdustinface merged commit 5992358 into v0.42-dev Feb 26, 2026
77 checks passed
@xdustinface xdustinface deleted the chore/remove-unified-sdk branch February 26, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants