chore: remove unified sdk references#302
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
💤 Files with no reviewable changes (5)
📝 WalkthroughWalkthroughRemoves all references and documentation related to the Unified SDK integration from the project. This includes deleting the dedicated UNIFIED_SDK.md documentation file and removing Unified SDK build instructions, recommendations, and notes from various README files across multiple directories. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ``` | ||
|
|
||
| **Important**: The unified SDK build process (`build_ios.sh`) merges dash-spv-ffi with platform SDK. You MUST build dash-spv-ffi first or changes won't be included! | ||
|
|
There was a problem hiding this comment.
what about removing the build-ios.sh script??
There was a problem hiding this comment.
Yeah makes sense, will drop it in #296 or a separate PR.
Drop UNIFIED_SDK.md and references to it.
Summary by CodeRabbit