chore(release): update changelog and bump version to 2.1.0-dev.5#2782
chore(release): update changelog and bump version to 2.1.0-dev.5#2782
Conversation
WalkthroughVersion bumped from dev.4 to dev.5 across multiple packages (JS, Rust, and WASM). CHANGELOG.md updated with a new 2.1.0-dev.5 entry noting a Drive subscription filter feature and an SDK npm packaging fix. No code or API changes; only metadata updates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ gRPC Query Coverage Report |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/withdrawals-contract/Cargo.toml (1)
3-3: Typo in package description.Fix “Witdrawals” → “Withdrawals”.
-description = "Witdrawals data contract schema and tools" +description = "Withdrawals data contract schema and tools"packages/rs-dpp/Cargo.toml (3)
96-139: Deduplicate “state-transitions” in all_features.It appears twice; features are idempotent but duplicate entries add noise.
all_features = [ "json-object", "all-system_contracts", - "state-transitions", "extended-document", "bls-signatures", "cbor", "validation", "identity-hashing", "identity-serialization", "ciborium", "core-types", "core-types-serialization", "core-types-serde-conversion", "document-serde-conversion", "document-value-conversion", "document-json-conversion", "document-cbor-conversion", "data-contract-serde-conversion", "data-contract-value-conversion", "data-contract-json-conversion", "identity-serde-conversion", "identity-value-conversion", "identity-json-conversion", "identity-cbor-conversion", "index-serde-conversion", "state-transition-serde-conversion", "state-transition-value-conversion", "state-transition-json-conversion", "state-transition-validation", "state-transition-signing", - "state-transitions", "factories", "fixtures-and-mocks", "random-public-keys", "random-identities", "random-documents", "random-document-types", "fee-distribution", "client", "vote-serialization", "token-reward-explanations" ]
151-193: Deduplicate “state-transitions” in all_features_without_client.Same duplication here; trim the second occurrence.
all_features_without_client = [ "json-object", "platform-value", "all-system_contracts", - "state-transitions", "extended-document", "cbor", "validation", "identity-hashing", "identity-serialization", "ciborium", "core-types", "core-types-serialization", "core-types-serde-conversion", "document-serde-conversion", "document-value-conversion", "document-json-conversion", "document-cbor-conversion", "data-contract-serde-conversion", "data-contract-value-conversion", "data-contract-json-conversion", "data-contract-cbor-conversion", "identity-serde-conversion", "identity-value-conversion", "identity-json-conversion", "identity-cbor-conversion", "index-serde-conversion", "state-transition-serde-conversion", "state-transition-value-conversion", "state-transition-json-conversion", "state-transition-validation", "state-transition-signing", - "state-transitions", "factories", "fixtures-and-mocks", "random-public-keys", "random-identities", "random-documents", "random-document-types", "fee-distribution", "vote-serialization", "vote-serde-conversion", ]
215-215: Fix typo in TODO.Minor wording nit.
-# TODO: Tring to remove regexp +# TODO: Trying to remove regexp
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (59)
CHANGELOG.md(1 hunks)package.json(1 hunks)packages/bench-suite/package.json(1 hunks)packages/check-features/Cargo.toml(1 hunks)packages/dapi-grpc/Cargo.toml(1 hunks)packages/dapi-grpc/package.json(1 hunks)packages/dapi/package.json(1 hunks)packages/dash-platform-balance-checker/Cargo.toml(1 hunks)packages/dash-spv/package.json(1 hunks)packages/dashmate/package.json(1 hunks)packages/dashpay-contract/Cargo.toml(1 hunks)packages/dashpay-contract/package.json(1 hunks)packages/data-contracts/Cargo.toml(1 hunks)packages/dpns-contract/Cargo.toml(1 hunks)packages/dpns-contract/package.json(1 hunks)packages/feature-flags-contract/Cargo.toml(1 hunks)packages/feature-flags-contract/package.json(1 hunks)packages/js-dapi-client/package.json(1 hunks)packages/js-dash-sdk/package.json(1 hunks)packages/js-evo-sdk/package.json(1 hunks)packages/js-grpc-common/package.json(1 hunks)packages/keyword-search-contract/Cargo.toml(1 hunks)packages/keyword-search-contract/package.json(1 hunks)packages/masternode-reward-shares-contract/Cargo.toml(1 hunks)packages/masternode-reward-shares-contract/package.json(1 hunks)packages/platform-test-suite/package.json(1 hunks)packages/rs-context-provider/Cargo.toml(1 hunks)packages/rs-dapi-client/Cargo.toml(1 hunks)packages/rs-dapi-grpc-macros/Cargo.toml(1 hunks)packages/rs-dpp/Cargo.toml(1 hunks)packages/rs-drive-abci/Cargo.toml(1 hunks)packages/rs-drive-proof-verifier/Cargo.toml(1 hunks)packages/rs-drive/Cargo.toml(1 hunks)packages/rs-json-schema-compatibility-validator/Cargo.toml(1 hunks)packages/rs-platform-serialization-derive/Cargo.toml(1 hunks)packages/rs-platform-serialization/Cargo.toml(1 hunks)packages/rs-platform-value-convertible/Cargo.toml(1 hunks)packages/rs-platform-value/Cargo.toml(1 hunks)packages/rs-platform-version/Cargo.toml(1 hunks)packages/rs-platform-versioning/Cargo.toml(1 hunks)packages/rs-platform-wallet/Cargo.toml(1 hunks)packages/rs-sdk-ffi/Cargo.toml(1 hunks)packages/rs-sdk-trusted-context-provider/Cargo.toml(1 hunks)packages/rs-sdk/Cargo.toml(1 hunks)packages/simple-signer/Cargo.toml(1 hunks)packages/strategy-tests/Cargo.toml(1 hunks)packages/token-history-contract/Cargo.toml(1 hunks)packages/token-history-contract/package.json(1 hunks)packages/wallet-lib/package.json(1 hunks)packages/wallet-utils-contract/Cargo.toml(1 hunks)packages/wallet-utils-contract/package.json(1 hunks)packages/wasm-dpp/Cargo.toml(1 hunks)packages/wasm-dpp/package.json(1 hunks)packages/wasm-drive-verify/Cargo.toml(1 hunks)packages/wasm-drive-verify/package.json(1 hunks)packages/wasm-sdk/Cargo.toml(1 hunks)packages/wasm-sdk/package.json(1 hunks)packages/withdrawals-contract/Cargo.toml(1 hunks)packages/withdrawals-contract/package.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
packages/platform-test-suite/**
📄 CodeRabbit inference engine (AGENTS.md)
packages/platform-test-suite/**: Keep end-to-end tests and helpers in packages/platform-test-suite
Keep all E2E tests exclusively in packages/platform-test-suite
Files:
packages/platform-test-suite/package.json
packages/wasm-sdk/**
📄 CodeRabbit inference engine (CLAUDE.md)
Keep WASM SDK docs in sync (run generate_docs.py) when updating the WASM SDK
Files:
packages/wasm-sdk/package.jsonpackages/wasm-sdk/Cargo.toml
packages/rs-sdk-ffi/**
📄 CodeRabbit inference engine (AGENTS.md)
Keep iOS/FFI Rust SDK artifacts in packages/rs-sdk-ffi
Files:
packages/rs-sdk-ffi/Cargo.toml
🧠 Learnings (14)
📚 Learning: 2025-09-12T13:18:08.661Z
Learnt from: CR
PR: dashpay/platform#0
File: AGENTS.md:0-0
Timestamp: 2025-09-12T13:18:08.661Z
Learning: Applies to packages/platform-test-suite/** : Keep end-to-end tests and helpers in packages/platform-test-suite
Applied to files:
packages/platform-test-suite/package.json
📚 Learning: 2025-01-19T07:36:46.042Z
Learnt from: QuantumExplorer
PR: dashpay/platform#2431
File: packages/rs-drive/Cargo.toml:55-60
Timestamp: 2025-01-19T07:36:46.042Z
Learning: The grovedb dependencies in packages/rs-drive/Cargo.toml and related files are intentionally kept at specific revisions rather than using the latest stable version, with plans to update them at a later time.
Applied to files:
packages/rs-platform-serialization/Cargo.tomlpackages/rs-platform-serialization-derive/Cargo.tomlpackages/rs-platform-version/Cargo.tomlpackages/rs-dpp/Cargo.tomlpackages/wasm-drive-verify/Cargo.tomlpackages/rs-drive/Cargo.tomlpackages/rs-dapi-client/Cargo.tomlpackages/rs-platform-wallet/Cargo.tomlpackages/rs-json-schema-compatibility-validator/Cargo.tomlpackages/rs-platform-versioning/Cargo.tomlpackages/rs-platform-value-convertible/Cargo.tomlpackages/rs-drive-abci/Cargo.tomlpackages/rs-drive-proof-verifier/Cargo.tomlpackages/rs-sdk-ffi/Cargo.tomlpackages/rs-platform-value/Cargo.toml
📚 Learning: 2025-09-03T14:42:29.958Z
Learnt from: thephez
PR: dashpay/platform#2754
File: packages/wasm-sdk/docs.html:1970-1971
Timestamp: 2025-09-03T14:42:29.958Z
Learning: In packages/wasm-sdk/, the docs.html file is auto-generated from api-definitions.json. Any documentation fixes should be made in api-definitions.json rather than directly in docs.html, as manual changes to docs.html would be overwritten during regeneration.
Applied to files:
packages/wasm-sdk/package.jsonpackages/wasm-sdk/Cargo.toml
📚 Learning: 2025-09-07T22:18:50.883Z
Learnt from: CR
PR: dashpay/platform#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-07T22:18:50.883Z
Learning: Applies to packages/wasm-sdk/** : Keep WASM SDK docs in sync (run generate_docs.py) when updating the WASM SDK
Applied to files:
packages/wasm-sdk/package.jsonpackages/wasm-sdk/Cargo.toml
📚 Learning: 2025-09-03T14:41:16.196Z
Learnt from: thephez
PR: dashpay/platform#2754
File: packages/wasm-sdk/AI_REFERENCE.md:766-766
Timestamp: 2025-09-03T14:41:16.196Z
Learning: In packages/wasm-sdk/, the AI_REFERENCE.md file is auto-generated from api-definitions.json. Any documentation fixes should be made in api-definitions.json rather than directly in AI_REFERENCE.md, as manual changes to AI_REFERENCE.md would be overwritten during regeneration.
Applied to files:
packages/wasm-sdk/package.jsonpackages/wasm-sdk/Cargo.toml
📚 Learning: 2024-10-18T15:39:51.172Z
Learnt from: lklimek
PR: dashpay/platform#2254
File: packages/rs-sdk/src/sdk.rs:585-585
Timestamp: 2024-10-18T15:39:51.172Z
Learning: The 'platform' project uses Rust version 1.80, so code in 'packages/rs-sdk' can use features available in Rust 1.80, such as the `abs_diff()` method.
Applied to files:
packages/rs-platform-version/Cargo.tomlpackages/rs-sdk-trusted-context-provider/Cargo.tomlpackages/wasm-sdk/Cargo.tomlpackages/rs-platform-wallet/Cargo.tomlpackages/rs-platform-versioning/Cargo.tomlpackages/rs-platform-value-convertible/Cargo.tomlpackages/rs-sdk/Cargo.tomlpackages/rs-platform-value/Cargo.toml
📚 Learning: 2024-10-08T13:28:03.529Z
Learnt from: QuantumExplorer
PR: dashpay/platform#2227
File: packages/rs-drive-abci/src/platform_types/platform_state/mod.rs:141-141
Timestamp: 2024-10-08T13:28:03.529Z
Learning: When converting `PlatformStateV0` to `PlatformStateForSavingV1` in `packages/rs-drive-abci/src/platform_types/platform_state/mod.rs`, only version `0` needs to be handled in the match on `platform_state_for_saving_structure_default` because the changes are retroactive.
Applied to files:
packages/rs-platform-version/Cargo.tomlpackages/rs-platform-versioning/Cargo.tomlpackages/rs-platform-value-convertible/Cargo.toml
📚 Learning: 2024-12-05T09:29:38.918Z
Learnt from: shumkov
PR: dashpay/platform#2375
File: packages/rs-drive-abci/Cargo.toml:61-63
Timestamp: 2024-12-05T09:29:38.918Z
Learning: In the `drive-abci` package, avoid adding unused dependencies like `hashbrown` to `Cargo.toml`. The team relies on CI to detect dependency version issues.
Applied to files:
packages/rs-drive/Cargo.tomlpackages/rs-drive-abci/Cargo.toml
📚 Learning: 2024-10-29T10:42:00.521Z
Learnt from: lklimek
PR: dashpay/platform#2277
File: packages/rs-dapi-client/Cargo.toml:22-22
Timestamp: 2024-10-29T10:42:00.521Z
Learning: In `packages/rs-dapi-client/Cargo.toml`, `backon` will not work without the `tokio-sleep` feature in our setup, so it's unnecessary to declare `tokio-sleep` as a separate feature in the `[features]` section.
Applied to files:
packages/rs-dapi-client/Cargo.toml
📚 Learning: 2025-09-03T16:37:11.605Z
Learnt from: QuantumExplorer
PR: dashpay/platform#2756
File: packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_list/update_state_masternode_list/v0/mod.rs:11-11
Timestamp: 2025-09-03T16:37:11.605Z
Learning: In packages/rs-dpp/Cargo.toml, the abci feature already includes core_rpc_client, and core_rpc_client is defined as ["dep:dashcore-rpc"]. This means rs-drive-abci can access dashcore-rpc types through dpp when using the abci feature.
Applied to files:
packages/rs-dapi-client/Cargo.tomlpackages/rs-drive-abci/Cargo.toml
📚 Learning: 2025-09-07T22:18:50.883Z
Learnt from: CR
PR: dashpay/platform#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-07T22:18:50.883Z
Learning: Applies to packages/rs-sdk-ffi/**/*.{h,rs} : Follow unified SDK function prefixes: dash_core_sdk_* for Core, dash_sdk_* for Platform, dash_unified_sdk_* for unified APIs
Applied to files:
packages/rs-sdk/Cargo.tomlpackages/rs-sdk-ffi/Cargo.toml
📚 Learning: 2025-03-11T09:39:23.071Z
Learnt from: shumkov
PR: dashpay/platform#2489
File: packages/rs-dpp/Cargo.toml:32-32
Timestamp: 2025-03-11T09:39:23.071Z
Learning: In the Dash Platform project, dependencies are currently managed using Git repository references with tags (repo+tag format in Cargo.toml) rather than published crates, as the team is not currently publishing crates to crates.io.
Applied to files:
packages/rs-sdk/Cargo.toml
📚 Learning: 2025-09-07T22:19:59.217Z
Learnt from: CR
PR: dashpay/platform#0
File: packages/swift-sdk/SwiftExampleApp/CLAUDE.md:0-0
Timestamp: 2025-09-07T22:19:59.217Z
Learning: Applies to packages/swift-sdk/SwiftExampleApp/**/*.swift : Use Platform SDK functions with the dash_sdk_* prefix
Applied to files:
packages/rs-sdk/Cargo.toml
📚 Learning: 2025-09-12T13:18:08.661Z
Learnt from: CR
PR: dashpay/platform#0
File: AGENTS.md:0-0
Timestamp: 2025-09-12T13:18:08.661Z
Learning: Applies to packages/rs-sdk-ffi/** : Keep iOS/FFI Rust SDK artifacts in packages/rs-sdk-ffi
Applied to files:
packages/rs-sdk-ffi/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (143)
- GitHub Check: Rust packages (withdrawals-contract) / Detect immutable structure changes
- GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust packages (withdrawals-contract) / Detect immutable structure changes
- GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
- GitHub Check: Rust packages (withdrawals-contract) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
- GitHub Check: Rust packages (withdrawals-contract) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
- GitHub Check: Rust packages (withdrawals-contract) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust packages (withdrawals-contract) / Linting
- GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
- GitHub Check: Rust packages (withdrawals-contract) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust packages (withdrawals-contract) / Linting
- GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
- GitHub Check: Rust packages (withdrawals-contract) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust packages (withdrawals-contract) / Linting
- GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
- GitHub Check: Rust packages (withdrawals-contract) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust packages (withdrawals-contract) / Linting
- GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
- GitHub Check: Rust packages (withdrawals-contract) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (59)
packages/withdrawals-contract/Cargo.toml (1)
4-4: Crate version bump is correct.Aligned with the workspace release to 2.1.0-dev.5.
packages/rs-platform-serialization/Cargo.toml (1)
5-5: Version bump acknowledged.No other manifest changes; OK for release.
packages/rs-drive-abci/Cargo.toml (1)
3-3: drive-abci crate bump looks good.No dependency drift introduced here. Proceed.
packages/dashpay-contract/package.json (1)
3-3: dashpay-contract version bump approved.
Confirmed packages/dashpay-contract/Cargo.toml contains version = "2.1.0-dev.5" (line 4).packages/wasm-dpp/package.json (1)
3-3: Bump to 2.1.0-dev.5 approved — Cargo.toml matches; no older tag refs found.
packages/wasm-dpp/Cargo.toml (line 3) = "2.1.0-dev.5"; no occurrences of "dev.4" under packages/wasm-dpp.packages/withdrawals-contract/package.json (1)
3-3: Approve version bump to 2.1.0-dev.5 — verifiedNo lingering 2.1.0-dev.4 / 5.1.0-dev.4 references; JS package.json and Cargo.toml versions are aligned to 2.1.0-dev.5 and CHANGELOG top entry shows v2.1.0-dev.5 (2025-09-19).
packages/js-dash-sdk/package.json (1)
3-3: SDK version bump to 5.1.0-dev.5 — LGTM (manual checks required).Automated search couldn't read repo files; confirm:
- No docs/examples still pin dash@5.1.0-dev.4 (search docs/, examples/, README.md and other package.json files).
- CHANGELOG/release notes include the "npm packaging" fix in 5.1.0-dev.5 (check CHANGELOG.md or packages/js-dash-sdk changelog).
packages/data-contracts/Cargo.toml (1)
4-4: Confirm dependent crates referencing data-contractsAutomated search couldn't access repository files; unable to verify the version bump. Run locally:
git grep -n "data-contracts" || true rg -n --hidden -g '!**/target/**' '^\s*data-contracts\s*=' || true rg -n --hidden -g '!**/target/**' '2\.1\.0-dev\.5' || trueUpdate any Cargo.toml entries that pin an older version to 2.1.0-dev.5 or ensure path deps remain correct.
packages/wasm-drive-verify/package.json (1)
6-6: Version bump looks good.The version update from 2.1.0-dev.4 to 2.1.0-dev.5 is consistent with the PR objectives for this release.
packages/js-grpc-common/package.json (1)
3-3: Version bump looks good.The version update from 2.1.0-dev.4 to 2.1.0-dev.5 aligns with the repository-wide release update.
packages/rs-platform-value/Cargo.toml (1)
5-5: Version bump looks good.The crate version update from 2.1.0-dev.4 to 2.1.0-dev.5 is consistent with the coordinated release across the monorepo.
packages/rs-dapi-client/Cargo.toml (1)
3-3: Version bump looks good.The crate version update from 2.1.0-dev.4 to 2.1.0-dev.5 follows the expected pattern for this coordinated release.
packages/dapi/package.json (1)
4-4: Version bump looks good.The package version update from 2.1.0-dev.4 to 2.1.0-dev.5 is consistent with the monorepo-wide version bump for this release.
packages/dapi-grpc/package.json (1)
3-3: Version bump looks good.The @dashevo/dapi-grpc package version update from 2.1.0-dev.4 to 2.1.0-dev.5 aligns with the coordinated release across all packages.
packages/wallet-lib/package.json (1)
3-3: Version bump follows expected pattern.The wallet-lib package uses its own versioning scheme (9.1.0-dev.5) which follows the same dev.4 to dev.5 increment pattern as the platform packages, maintaining consistency across the release.
packages/dpns-contract/package.json (1)
3-3: Version bump looks good.The @dashevo/dpns-contract package version update from 2.1.0-dev.4 to 2.1.0-dev.5 completes the coordinated version bump across the repository.
packages/js-evo-sdk/package.json (1)
3-3: Version bump only; packaging config unchanged.Main/exports point to dist and files includes dist/**; looks fine for publish.
packages/token-history-contract/package.json (1)
3-3: Version field updated as part of release; no other changes.All good.
packages/feature-flags-contract/package.json (1)
3-3: Version bump is consistent with the release.No functional changes; OK to merge.
packages/masternode-reward-shares-contract/package.json (1)
3-3: Version bump only; matches repo-wide update.Looks good.
packages/rs-dapi-grpc-macros/Cargo.toml (1)
4-4: Crate version bumped; proc-macro crate config unchanged.No API/dep changes; OK.
packages/masternode-reward-shares-contract/Cargo.toml (1)
4-4: Cargo package version updated; dependencies unchanged.Looks consistent with the release plan.
packages/rs-drive/Cargo.toml (1)
4-4: Bump looks correct; grovedb pins unchanged.All package manifests (Cargo.toml/package.json) updated to 2.1.0-dev.5; the only remaining dev.4 mention is CHANGELOG.md; grovedb git revs in Cargo.toml remain pinned. LGTM.
packages/rs-sdk-ffi/Cargo.toml (1)
3-3: FFI crate version bump — confirm no other crate emits staticlib/cdylibSandbox ripgrep runs were inconclusive (rg skipped files); cbindgen references exist in packages/swift-sdk (generated headers). Verify locally that only packages/rs-sdk-ffi emits FFI artifacts by running:
#!/bin/bash set -euo pipefail echo "Checking Cargo.toml for crate-type entries with staticlib/cdylib (excluding rs-sdk-ffi)..." find . -name Cargo.toml -not -path './packages/rs-sdk-ffi/*' -print0 | xargs -0 -n1 rg -nP '^\s*crate-type\s*=\s*\[.*\b(staticlib|cdylib)\b.*\]' -H || echo "OK: no extra FFI crate-types outside rs-sdk-ffi" echo echo "Searching for inner crate_type attributes in source files:" rg -nP '#!\s*\[\s*crate_type\s*=' -S --hidden || echo "OK: no inner crate_type attributes found" echo echo "List cbindgen mentions outside packages/rs-sdk-ffi:" rg -nP 'cbindgen' -n packages | rg -v 'packages/rs-sdk-ffi' || echo "No cbindgen mentions outside rs-sdk-ffi"packages/check-features/Cargo.toml (1)
3-3: Simple bump approved.No dependency or feature changes. Safe to merge.
packages/feature-flags-contract/Cargo.toml (1)
4-4: Crate version bump approved.No dependency changes; internal path deps remain untouched.
packages/bench-suite/package.json (1)
4-4: Approve: bench-suite version bump is safe (package is private)
Verified packages/bench-suite/package.json contains "private": true; no publish impact.packages/wasm-drive-verify/Cargo.toml (1)
3-3: Bump approved — workspace toolchain >= 1.89 confirmed. rust-toolchain.toml sets channel = "1.89"; root Cargo.toml (line 45) and packages/wasm-drive-verify/Cargo.toml (line 6) specify rust-version = "1.89"; many crates use rust-version.workspace = true.packages/dashmate/package.json (1)
3-3: Dashmate bump OK — README updated; oclif manifest missing, verify artifact generationpackages/dashmate/README.md exists (modified Sep 19 09:13); packages/dashmate/oclif.manifest.json not found. Ensure the version script regenerates the oclif manifest (or commit the generated manifest) and confirm its path if it's written elsewhere.
packages/platform-test-suite/package.json (1)
4-4: Approve: test-suite version bump — no E2E specs found outside packages/platform-test-suite.
rg sweep shows only test/unit and test/integration files outside this package; no /e2e/ or e2e-named specs detected.packages/rs-platform-versioning/Cargo.toml (1)
5-5: LGTM — workspace updated to 2.1.0-dev.5; create annotated dev.5 tags.
- Search confirms manifests/package.json entries set to "2.1.0-dev.5"; no leftover -dev.4 in manifests (only historical references in CHANGELOG.md).
- git tag -l 'dev.5' returned no tags — create annotated tags matching the new crate versions (e.g., v2.1.0-dev.5) before publishing.
packages/dash-spv/package.json (1)
3-3: Version bump OK — confirm changelog & engine/peer constraints
- Repo scan: no package.json peerDependencies reference "dev.*" (packages/dash-spv/package.json included).
- Before publishing: ensure changelog/release notes cover the bump and verify "engines" and peer dependency constraints do not pin older versions (engines check was not completed).
packages/rs-sdk/Cargo.toml (1)
3-3: Crate version bump is consistent.No API/deps changes detected here.
packages/rs-context-provider/Cargo.toml (1)
3-3: Version bump only; OK.packages/rs-platform-serialization-derive/Cargo.toml (1)
5-5: Derive crate version updated; OK.packages/token-history-contract/Cargo.toml (1)
4-4: Contract crate version bump only; OK.packages/dapi-grpc/Cargo.toml (1)
4-4: dapi-grpc version bump looks good.No changes to protobuf or tonic versions; safe metadata update.
packages/wasm-sdk/Cargo.toml (1)
3-3: WASM SDK version bump OK — confirm docs regenerated
- Cargo.toml and packages/wasm-sdk/package.json both set to 2.1.0-dev.5 (confirmed).
- Regenerate docs from api-definitions.json and ensure packages/wasm-sdk/AI_REFERENCE.md and docs.html reflect 2.1.0-dev.5 and contain no references to 2.1.0-dev.4.
packages/keyword-search-contract/package.json (1)
3-3: Verify Cargo.toml version matches package.json (fix verifier and re-run)The prior check showed "Mismatch: package.json=2.1.0-dev.5 Cargo.toml=4:2.1.0-dev.5" because the extractor included a line-number prefix; run this corrected verifier to compare the actual versions:
#!/bin/bash set -euo pipefail pkg_ver=$(jq -r .version packages/keyword-search-contract/package.json) toml_ver=$(awk ' /^[[:space:]]*\[package\]/ {in_pkg=1; next} in_pkg && /^[[:space:]]*\[/{in_pkg=0} in_pkg && match($0,/^[[:space:]]*version[[:space:]]*=[[:space:]]*"(.*)"/,m){print m[1]; exit} ' packages/keyword-search-contract/Cargo.toml) test "$pkg_ver" = "$toml_ver" && echo "OK: $pkg_ver" || { echo "Mismatch: package.json=$pkg_ver Cargo.toml=$toml_ver"; exit 1; }package.json (1)
3-3: Root version updated; sweep for stragglers.rg reported "No files were searched" — re-run a repo-wide search from the repository root with one of these commands:
# Tracked files (fast) git grep -n '2.1.0-dev.4' || echo "No references in tracked files." # ripgrep (search everything, ignore .gitignore) rg -n --hidden --no-ignore -S '2\.1\.0-dev\.4' --glob '!node_modules/**' --glob '!target/**' || echo "No leftovers found." # Portable fallback grep -RIn --exclude-dir={.git,node_modules,target} '2.1.0-dev.4' . || echo "No leftovers found."packages/rs-drive-proof-verifier/Cargo.toml (1)
3-3: LGTM: crate version → 2.1.0-dev.5Manifest-only change; no API impact.
packages/rs-sdk-trusted-context-provider/Cargo.toml (1)
3-3: LGTM: metadata bump only.No feature/deps changes; safe to merge.
packages/keyword-search-contract/Cargo.toml (1)
4-4: LGTM: version bump.No other manifest changes observed.
packages/strategy-tests/Cargo.toml (1)
3-3: LGTM: test crate version bumped.No runtime impact.
packages/simple-signer/Cargo.toml (1)
3-3: LGTM: simple-signer version bump.No changes to features/deps.
packages/js-dapi-client/package.json (1)
3-3: LGTM: js dapi-client version bumped.No functional changes; package scripts/exports unchanged.
packages/wasm-sdk/package.json (1)
3-3: WASM SDK bump — regenerate docs from api-definitions.json and commit any changes.Presence check passed and no '2.1.0-dev.4' references found.
- Run the docs generator for packages/wasm-sdk (generate_docs.py) and commit any diffs to packages/wasm-sdk/docs.html and packages/wasm-sdk/AI_REFERENCE.md.
- Sanity-check packaging after #2780.
packages/dashpay-contract/Cargo.toml (1)
4-4: Approve — version bumped to 2.1.0-dev.5; no stale 2.1.0-dev.4 outside CHANGELOG.md.
- packages/dashpay-contract/Cargo.toml: version = "2.1.0-dev.5".
- Exact "2.1.0-dev.4" only found in CHANGELOG.md (expected compare links).
- Unrelated "dev.4" occurrences in packages/dashmate/configs/getConfigFileMigrationsFactory.js (1.0.0-dev.4, 1.4.0-dev.4).
CHANGELOG.md (1)
1-12: Changelog entry reads well — validate tag creation & compare link.Script shows "release not found" for v2.1.0-dev.4, "v2.1.0-dev.5 not created yet", and the compare URL returned 404. Ensure the release workflow creates tag v2.1.0-dev.5 on merge so the compare link resolves, or update the changelog to use a commit-range link.
packages/rs-dpp/Cargo.toml (1)
3-3: Version bump verified — workspace-wide sync confirmed. All Cargo.toml and top-level package.json files were updated to 2.1.0-dev.5; no 2.1.0-dev.4 stragglers found. Minor notes: packages/wallet-lib (9.1.0-dev.5), packages/js-dash-sdk (5.1.0-dev.5), packages/dash-spv (3.1.0-dev.5) keep their own majors (expected); packages/dashmate/package.json has a 'version' npm script at line 9 — confirm intentional. Update lockfiles (yarn.lock/Cargo.lock) if publishing.packages/rs-platform-value-convertible/Cargo.toml (1)
5-5: Proc-macro crate version bump looks correct.No dependency drift introduced.
packages/rs-platform-wallet/Cargo.toml (1)
3-3: Wallet crate version bump aligned.Since dependencies here are path/git pinned, no lockfile shifts expected; just confirm companion crates in this release also carry 2.1.0-dev.5.
packages/rs-platform-version/Cargo.toml (1)
5-5: Core versioning crate bump looks good.Downstream crates reference this via path; no semver constraint issues.
packages/dash-platform-balance-checker/Cargo.toml (1)
3-3: CLI tools version updated—OK.No runtime/config changes in bins; safe to merge.
packages/wallet-utils-contract/package.json (1)
3-3: Package.json version bump OK; check workspace linkage.Ensure all workspace:* deps (e.g., @dashevo/wasm-dpp) also reflect 2.1.0-dev.5 before publish.
packages/wasm-dpp/Cargo.toml (1)
3-3: wasm-dpp crate version bump looks consistent.Note: wasm-bindgen is pinned (=0.2.100). Confirm scripts/Dockerfile references are already aligned per the inline TODO.
packages/rs-json-schema-compatibility-validator/Cargo.toml (1)
3-3: Validator crate version bump is straightforward.No dependency or feature changes detected.
packages/dpns-contract/Cargo.toml (1)
4-4: Version bump LGTM — re-run dev.4 scanManifests show 2.1.0-dev.5, but the earlier search reported "No files were searched" (inconclusive). Re-run an exhaustive check:
rg -n --hidden --no-ignore -g '*.{toml,json,md}' '2\.1\.0-dev\.4' || echo "None found"packages/wallet-utils-contract/Cargo.toml (1)
4-4: Version bump verified — LGTM.All Cargo.toml and package.json entries updated to 2.1.0-dev.5; only remaining 2.1.0-dev.4 reference is the previous-release entry in CHANGELOG.md (CHANGELOG.md:13).
Issue being fixed or feature implemented
Release new Dash Platform version
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit