fix(sdk): fix generate docs#2730
Merged
QuantumExplorer merged 4 commits intodashpay:feat/implement-missing-token-transitions-wasm-sdkfrom Aug 19, 2025
Merged
Conversation
Add sdk_params to api-definitions.json and update generate_docs.py to use them for accurate SDK documentation while preserving UI compatibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…criptions Update generated docs.html and manifest to reflect accurate SDK method signatures for identity create/topup operations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…n parameters Regenerate AI_REFERENCE.md to reflect accurate SDK method signatures and parameter descriptions for identity create/topup operations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Collaborator
Author
|
Related to #2728 |
6 tasks
QuantumExplorer
approved these changes
Aug 19, 2025
b8a7ba5
into
dashpay:feat/implement-missing-token-transitions-wasm-sdk
6 checks passed
6 tasks
lklimek
pushed a commit
that referenced
this pull request
Sep 1, 2025
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The WASM SDK documentation generation was producing incorrect parameter descriptions for identityCreate and identityTopUp state transitions. The generated documentation showed UI-oriented parameters instead of the actual SDK method signatures, causing confusion for developers using the SDK.
What was done?
correct SDK method parameters
The solution maintains backward compatibility for the UI (index.html) while providing accurate documentation for SDK
consumers.
How Has This Been Tested?
Breaking Changes
None. This change only affects documentation generation and maintains full compatibility with existing UI and SDK functionality.
Checklist:
For repository code-owners and collaborators only