fix(platform)!: update keyword search contract ID and owner ID bytes#2693
fix(platform)!: update keyword search contract ID and owner ID bytes#2693QuantumExplorer merged 2 commits intov2.0-devfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Issue being fixed or feature implemented
Two system data contracts are both using the same contract id... which is a big big no no. We uncovered this at the last minute, and will need to do an emergency release before 2.0.0. The reason this was not discovered on testnet was because it affected the wallet utils data contract which was not part of our CI processes.
What was done?
contractIdinsystemIds.jsto a new value.ID_BYTESarray inlib.rswith new byte values for the owner ID.How Has This Been Tested?
The changes were tested through existing unit tests that validate the contract ID and owner ID functionality.
Breaking Changes
This is an emergency breaking change.
Checklist
For repository code-owners and collaborators only