Skip to content

fix: proof result error for credit transfers in sdk #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 2 commits into from
Feb 4, 2025
Merged

fix: proof result error for credit transfers in sdk #2451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9bfa5b
fix: proof result error for credit transfers in sdk
pauldelucia Feb 4, 2025
ac8f617
return the receiver balance too
pauldelucia Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions packages/rs-sdk/src/platform/transition/transfer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pub trait TransferToIdentity: Waitable {
signing_transfer_key_to_use: Option<&IdentityPublicKey>,
signer: S,
settings: Option<PutSettings>,
) -> Result<u64, Error>;
) -> Result<(u64, u64), Error>;
}

#[async_trait::async_trait]
Expand All @@ -45,7 +45,7 @@ impl TransferToIdentity for Identity {
signing_transfer_key_to_use: Option<&IdentityPublicKey>,
signer: S,
settings: Option<PutSettings>,
) -> Result<u64, Error> {
) -> Result<(u64, u64), Error> {
let new_identity_nonce = sdk.get_identity_nonce(self.id(), true, settings).await?;
let user_fee_increase = settings.and_then(|settings| settings.user_fee_increase);
let state_transition = IdentityCreditTransferTransition::try_from_identity(
Expand All @@ -60,10 +60,21 @@ impl TransferToIdentity for Identity {
None,
)?;

let identity: PartialIdentity = state_transition.broadcast_and_wait(sdk, settings).await?;
let (sender, receiver): (PartialIdentity, PartialIdentity) =
state_transition.broadcast_and_wait(sdk, settings).await?;

identity.balance.ok_or(Error::DapiClientError(
"expected an identity balance after transfer".to_string(),
))
let sender_balance = sender.balance.ok_or_else(|| {
Error::DapiClientError(
"expected an identity balance after transfer (sender)".to_string(),
)
})?;

let receiver_balance = receiver.balance.ok_or_else(|| {
Error::DapiClientError(
"expected an identity balance after transfer (receiver)".to_string(),
)
})?;

Ok((sender_balance, receiver_balance))
}
}
Loading