fix(dashmate): container name is already in use by shumkov · Pull Request #2341 · dashpay/platform

shumkov · 2024-11-21T09:46:31Z

Issue being fixed or feature implemented

Error during ZeroSSL cert verification:

   ✖ (HTTP code 409) unexpected - Conflict. The container name "/dashmate-zerossl-validation" is already in use by container "e51b5d2bb4cf2e7bbaf4501dbe4d5e48c519a22d59471456407…

What was done?

Fixed container start error handling

How Has This Been Tested?

Running and canceling cert verification and start again

Breaking Changes

None

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

I have assigned this pull request to a milestone

Summary by CodeRabbit

New Features
- Enhanced error handling for Docker container creation with a retry mechanism.
- Improved robustness in managing existing containers during creation attempts.
Bug Fixes
- Adjusted error handling to throw errors for issues other than container not found.

coderabbitai · 2024-11-21T09:46:39Z

Walkthrough

The changes in this pull request focus on the VerificationServer class within VerificationServer.js. The start method has undergone significant modifications to enhance error handling, introducing a retry mechanism for container creation upon encountering a name conflict (409 error) and refining the logic for handling existing containers and error responses.

Changes

File Path	Change Summary
`packages/dashmate/src/listr/tasks/ssl/VerificationServer.js`	- Enhanced `start` method for improved error handling with a retry mechanism for 409 errors. - Updated logic for handling existing containers and refined error response handling.

Possibly related PRs

chore(dashmate): report port check errors #2245: This PR enhances error handling in the checkPortStatus method, which may relate to the improved error handling in the start method of the VerificationServer class in the main PR.
fix(dashmate): invalid drive status check #2248: This PR modifies the platform method to include better error handling for Docker status checks, which aligns with the main PR's focus on enhancing error handling in container creation.
fix(dashmate): zero ssl certificate draft not saved #2297: This PR addresses issues with saving ZeroSSL certificate drafts, which involves error handling in the context of SSL certificate management, similar to the error handling improvements in the main PR.
fix(dashmate): cleanup zerossl certs command #2298: This PR introduces a cleanup command for ZeroSSL certificates, which may relate to the overall error handling and management of SSL processes discussed in the main PR.

Suggested labels

dashmate

Suggested reviewers

QuantumExplorer
pshenmic

🐰 In the land of code where rabbits play,
A server's heart grew strong today.
With retries and checks, it hops along,
Creating containers, where they belong.
So let us cheer for the changes made,
In the world of tech, our skills displayed! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c7e8067 and b1d2e87.

📒 Files selected for processing (1)

packages/dashmate/src/listr/tasks/ssl/VerificationServer.js (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/dashmate/src/listr/tasks/ssl/VerificationServer.js

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

packages/dashmate/src/listr/tasks/ssl/VerificationServer.js (1)
102-109: Consider adding exponential backoff between retries

While the retry logic is solid, adding a small delay between retries could help in scenarios where the container cleanup takes longer than expected.
 const MAX_RETRIES = 3;
+const RETRY_DELAY_MS = 1000;
 while (!this.container && retries <= MAX_RETRIES) {
   try {
     this.container = await this.docker.createContainer(opts);
   } catch (e) {
     // Throw any other error except container name conflict
     if (e.statusCode !== 409) {
       throw e;
     }
+    // Add exponential backoff
+    await new Promise(resolve => setTimeout(resolve, RETRY_DELAY_MS * Math.pow(2, retries)));

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0cb24ea and c7e8067.

📒 Files selected for processing (1)

packages/dashmate/src/listr/tasks/ssl/VerificationServer.js (2 hunks)

🔇 Additional comments (2)

packages/dashmate/src/listr/tasks/ssl/VerificationServer.js (2)

100-102: LGTM! Well-structured retry mechanism

The implementation of a retry mechanism with a reasonable maximum retry count (3) is a good approach to handle container name conflicts.

111-126: LGTM! Robust error handling for container cleanup

The error handling for container removal and waiting is well implemented:

Properly handles dangling container removal
Correctly distinguishes between 404 (container not found) and other errors
Uses force removal to ensure cleanup succeeds

packages/dashmate/src/listr/tasks/ssl/VerificationServer.js

fix(dashmate): container name is already in use

c7e8067

shumkov added this to the v1.6.0 milestone Nov 21, 2024

shumkov requested a review from QuantumExplorer as a code owner November 21, 2024 09:46

shumkov self-assigned this Nov 21, 2024

coderabbitai bot reviewed Nov 21, 2024

View reviewed changes

packages/dashmate/src/listr/tasks/ssl/VerificationServer.js Outdated Show resolved Hide resolved

docs: fix Docker type

b1d2e87

pshenmic approved these changes Nov 21, 2024

View reviewed changes

shumkov merged commit f36588a into v1.6-dev Nov 21, 2024

shumkov deleted the fix/dashmate/container-already-started branch November 21, 2024 12:49

coderabbitai bot mentioned this pull request Dec 3, 2024

fix(dashmate): zero ssl verification passes without being verified #2365

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dashmate): container name is already in use#2341

fix(dashmate): container name is already in use#2341
shumkov merged 2 commits intov1.6-devfrom
fix/dashmate/container-already-started

shumkov commented Nov 21, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Nov 21, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

shumkov commented Nov 21, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shumkov commented Nov 21, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 21, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)