fix: correct double-slash paths in .tx/config file_filter entries#565
fix: correct double-slash paths in .tx/config file_filter entries#565thepastaclaw wants to merge 1 commit intodashpay:23.0.0from
Conversation
Multiple file_filter entries contained 'locale//<lang>' instead of 'locale/<lang>', which creates empty path segments that may break Transifex push/pull operations. Fixes dashpay#541
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@thepastaclaw did you actually verify that this is an issue? We haven't observed anything not working properly, so it's unclear to me that this change is necessary. See if you can conclusively determine this |
|
Good question — I should have verified this more carefully before opening the PR. Looking into it: on Unix systems, double slashes in paths ( So this is a consistency/hygiene fix, not a functional bug fix. 69 of the 76 If you'd rather not merge a cosmetic-only change, totally understand — happy to close it. But if consistency in the config file matters to you, the fix is correct. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
Fixes #541
All 69
file_filterentries in.tx/configcontained double slashes in their paths:This should be:
The empty path segment created by
//may cause issues with Transifex push/pull operations.Changes
file_filterpaths in.tx/configby replacinglocale//<lang>withlocale/<lang>Build output (Sphinx)
All 178 warnings are pre-existing and unrelated to this PR:
git.too_shallowwarnings (shallow clone, no git timestamps for source files)myst.xref_missingwarnings (DIP README cross-reference targets indocs/core/dips/)RemovedInSphinx90Warningdeprecation notices from hoverxref extensionNo new warnings or errors introduced by this change.
Environment: Python 3.14.3, Sphinx 8.1.3, macOS (arm64)