Skip to content

fix: correct double-slash paths in .tx/config file_filter entries#565

Open
thepastaclaw wants to merge 1 commit intodashpay:23.0.0from
thepastaclaw:fix-tx-config-double-slash
Open

fix: correct double-slash paths in .tx/config file_filter entries#565
thepastaclaw wants to merge 1 commit intodashpay:23.0.0from
thepastaclaw:fix-tx-config-double-slash

Conversation

@thepastaclaw
Copy link
Contributor

@thepastaclaw thepastaclaw commented Feb 16, 2026

Summary

Fixes #541

All 69 file_filter entries in .tx/config contained double slashes in their paths:

locale//<lang>/LC_MESSAGES/...

This should be:

locale/<lang>/LC_MESSAGES/...

The empty path segment created by // may cause issues with Transifex push/pull operations.

Changes

  • Fixed 69 file_filter paths in .tx/config by replacing locale//<lang> with locale/<lang>
  • No other files modified
Build output (Sphinx)
$ make html
build succeeded, 178 warnings.
The HTML pages are in _build/html.

All 178 warnings are pre-existing and unrelated to this PR:

  • git.too_shallow warnings (shallow clone, no git timestamps for source files)
  • myst.xref_missing warnings (DIP README cross-reference targets in docs/core/dips/)
  • RemovedInSphinx90Warning deprecation notices from hoverxref extension

No new warnings or errors introduced by this change.

Environment: Python 3.14.3, Sphinx 8.1.3, macOS (arm64)

Multiple file_filter entries contained 'locale//<lang>' instead of
'locale/<lang>', which creates empty path segments that may break
Transifex push/pull operations.

Fixes dashpay#541
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

Warning

Rate limit exceeded

@thepastaclaw has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 56 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thephez
Copy link
Collaborator

thephez commented Feb 16, 2026

@thepastaclaw did you actually verify that this is an issue? We haven't observed anything not working properly, so it's unclear to me that this change is necessary. See if you can conclusively determine this

@thepastaclaw
Copy link
Contributor Author

Good question — I should have verified this more carefully before opening the PR.

Looking into it: on Unix systems, double slashes in paths (locale//<lang>/...) are normalized to single slashes by the OS, so tx pull / tx push likely works fine in practice. The Transifex CLI probably never sees the double slash as an issue because path resolution handles it transparently.

So this is a consistency/hygiene fix, not a functional bug fix. 69 of the 76 file_filter entries have the double slash while 7 (the original entries) don't — it looks like a script that generated the newer entries had a trailing slash on a prefix that got concatenated with /<lang>/....

If you'd rather not merge a cosmetic-only change, totally understand — happy to close it. But if consistency in the config file matters to you, the fix is correct.

@thephez thephez changed the base branch from master to 23.0.0 February 16, 2026 21:16
@thepastaclaw
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix double-slash paths in .tx/config file_filter entries

2 participants