Conversation
…oupregtx # Conflicts: # lib/transaction/payload/index.js # package-lock.json
…ecialtx/qfcommit
[EV-1080] ProUpRegTx Transaction
…ecialtx/qfcommit
|
Aren't all the commits by Kamuela coming from the PR I reverted yesterday? |
|
@pvrooyen You can create a new branch from the current |
Author
|
@antouhou @KamuelaFranco - I just re-pulled from |
Cofresi
suggested changes
Oct 30, 2018
| * @property {string} signers byte[] (bitSize + 7) / 8 Bitset representing the aggregated signers of this final commitment | ||
| * @property {number} validMembersSize compactSize uint 1-9 Bit size of the validMembers bitvector | ||
| * @property {string} validMembers byte[] (bitSize + 7) / 8 Bitset of valid members in this commitment | ||
| * @property {string} quorumPublicKey BLSPubKey 64 The quorum public key |
There was a problem hiding this comment.
outdated specs
dashpay/dash#2296 (comment)
quorumPublicKey 48
quorumSig 96
sig 96
https://github.com/dashpay/dash/blob/develop/src/bls/bls.h#L23-L26
dashpay/dips#25
Cofresi
approved these changes
Oct 31, 2018
…ore-lib into specialtx/qfcommit
…mmit # Conflicts: # dist/dashcore-lib.js # dist/dashcore-lib.min.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or implemented
Added
CommitmentTxPayloadpayloadWhat was done
CommitmentTxPayloadpayload type;CommitmentTxPayloadclass toTransactionWhat has been tested
CommitmentTxPayloadparser;What needs to be tested
After commitment tx available in core get valid hex test vector and enhance tests
Code Coverage
All new code covered
Note
Merge @KamuelaFranco
ProUpRegfirst to get a better comparison on this pr