fix(qt): reseat quorum labels when new types are inserted#7191
fix(qt): reseat quorum labels when new types are inserted#7191PastaPastaPasta merged 1 commit intodashpay:developfrom
Conversation
When new quorum types appear during reindexing, existing labels that follow the insertion point in the grid were not being repositioned, causing overlapping text in the Information tab's Quorums section. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
WalkthroughThe change modifies Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…inserted 641b3ea fix(qt): reseat quorum labels when new types are inserted (UdjinM6) Pull request description: ## Issue being fixed or feature implemented When new quorum types appear during reindexing, existing labels that follow the insertion point in the grid were not being repositioned, causing overlapping text in the Information tab's Quorums section. before: <img width="292" height="173" alt="Screenshot 2026-03-01 at 13 56 12" src="https://github.com/user-attachments/assets/54daacde-6e44-4771-8478-00d11d93944a" /> after: <img width="282" height="188" alt="Screenshot 2026-03-02 at 19 07 23" src="https://github.com/user-attachments/assets/ed1f74c1-9c16-498b-ac7e-147f9601ba88" /> ## What was done? ## How Has This Been Tested? reindex with and without the patch on testnet ## Breaking Changes n/a ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone ACKs for top commit: kwvg: utACK 641b3ea Tree-SHA512: 6ab68bbda76975a2c2cec8a85e85c6ebc0a580dbf8012761a42c8d8d61e318d830bad47375a8af2d0c1754ef6c485f9204aa0e6d2f6898438d0699ebfbeadfa5
240a95f Merge #7193: fix: reject identity elements in deserialization and key generation (pasta) 444cbf2 Merge #7191: fix(qt): reseat quorum labels when new types are inserted (pasta) Pull request description: ## Backport Cherry-picks of #7191 and #7193 into `v23.1.x`. ### Included - #7193 — `fix: reject identity elements in deserialization and key generation` (42b707b) - #7191 — `fix(qt): reseat quorum labels when new types are inserted` (641b3ea) ACKs for top commit: UdjinM6: utACK 240a95f Tree-SHA512: dc270139159974b3bdab9177a7215de201d4deecc7883d47e35174fe7073c3508e61313e99e554b5a646ceb179202c96eb170e53dc9fc01177349aaa840acf2b
8d5936d chore: add #7191 and #7193 to v23.1.1 release notes (PastaClaw) 9f3662b chore: v23.1.1 release preparation (PastaClaw) 5dbfa98 chore: v23.1.1 release preparation (PastaClaw) Pull request description: ## v23.1.1 Release Preparation Version bump and release notes for v23.1.1. ### Changes - **Version bump:** `_CLIENT_VERSION_BUILD` 0 → 1 in `configure.ac` - **Release notes:** Written for all 12 backported PRs, following v23.0.2 format - **Archived:** v23.1.0 release notes to `doc/release-notes/dash/release-notes-23.1.0.md` - **Flatpak metainfo:** Added v23.1.0 and v23.1.1 release entries ### Notes - This PR should be merged **after** #7182 (the backport PR) lands on `v23.1.x` - `chainparams.cpp` updates (`nMinimumChainWork`, `defaultAssumeValid`) are not included — those should be done closer to tag time with fresh block data - Translations and manpages regeneration may need separate commits depending on process ACKs for top commit: UdjinM6: utACK 8d5936d Tree-SHA512: 9a4dca9635ee2bdecf224be928ce1e952c13256171a6e075793fefa074c1a1ee8b149a5b9853abe00ddb423bbecc7f5d5631d311a77c37ff6df5bca19c1c067f
Issue being fixed or feature implemented
When new quorum types appear during reindexing, existing labels that follow the insertion point in the grid were not being repositioned, causing overlapping text in the Information tab's Quorums section.
before:

after:

What was done?
How Has This Been Tested?
reindex with and without the patch on testnet
Breaking Changes
n/a
Checklist: