fix(qt): move MN/governance tab options from Wallet to Display settings

[thepastaclaw]

Summary

Move "Show Masternodes Tab", "Show Governance Tab", and "Show governance clock" checkboxes from the Wallet tab to the Display tab in the Options dialog.

These checkboxes control top-level UI tab visibility and are not wallet-specific settings. The Display tab is the natural home for UI visibility toggles.

Changes

• src/qt/forms/optionsdialog.ui: Relocated the three checkbox items from pageWallet to pageDisplay, with a horizontal line separator before them
• No changes to optionsdialog.cpp — all widget references use names, not page membership

Closes #7151

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

Walkthrough

This PR reorganizes the options dialog by relocating three UI controls related to Masternodes and Governance features from the Wallet configuration page to the Display configuration page. The affected controls include the Masternodes Tab checkbox, Governance Tab checkbox, and the governance cycle icon settings. The corresponding code logic in optionsdialog.cpp has been updated to reflect these relocations, including adjusting the UI element hiding behavior when wallet functionality is disabled and updating the property mappings accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The raw_summary shows code changes to optionsdialog.cpp (hiding elements, remapping widgets) that extend beyond the UI file relocation described in the PR description.	The PR description should document the optionsdialog.cpp changes that handle -disablewallet visibility and widget mapping updates to ensure these changes are intentional and aligned with the stated objectives.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: moving MN/governance tab options from Wallet to Display settings.
Description check	✅ Passed	The description clearly explains the rationale and changes, though it does not mention all code modifications made (optionsdialog.cpp changes).
Linked Issues check	✅ Passed	The PR successfully addresses all requirements from issue #7151: moving the three checkboxes (Show Masternodes Tab, Show Governance Tab, Show governance clock) from Wallet to Display tab.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[PastaPastaPasta]

ACK a6c6fb0

[UdjinM6]

1. line_2 is not rendered, should style it properly via css files, same as for existing line (QDialog#OptionsDialog #line in css)
2. line_2 and all moved checkboxes should be invisible when running qt with -disablewallet

[thepastaclaw]

Thanks for the review @UdjinM6! Both issues make sense:

1. line_2 CSS — will add it to the existing QDialog#OptionsDialog #line selectors in both dark.css and general.css
2. -disablewallet visibility — will hide line_2, showMasternodesTab, showGovernanceTab, and showGovernanceCycleIcon when wallet is disabled

Working on the fix now.

[UdjinM6]

1. line_2 CSS — will add it to the existing QDialog#OptionsDialog #line selectors in both dark.css and general.css

should adjust light.css too

[coderabbitai]

🧹 Nitpick comments (1)

src/qt/optionsdialog.cpp (1)

365-367: Nit: mapper mappings for relocated widgets still under the /* Wallet */ comment section.

Now that showMasternodesTab, showGovernanceTab, and showGovernanceCycleIcon live on the Display page, consider moving these three addMapping calls to the /* Display */ section (near line 394) to keep the code organization aligned with the UI layout.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/qt/optionsdialog.cpp` around lines 365 - 367, The three
mapper->addMapping calls for ui->showMasternodesTab,
ui->showGovernanceCycleIcon, and ui->showGovernanceTab are placed under the "/*
Wallet */" section but the widgets now live on the Display page; move those
three mapper->addMapping(...) lines out of the Wallet section into the "/*
Display */" section (near where other display-related mappings are added) so the
mappings for OptionsModel::ShowMasternodesTab,
OptionsModel::ShowGovernanceClock, and OptionsModel::ShowGovernanceTab are
grouped with Display-related code.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/qt/optionsdialog.cpp`:
- Around line 365-367: The three mapper->addMapping calls for
ui->showMasternodesTab, ui->showGovernanceCycleIcon, and ui->showGovernanceTab
are placed under the "/* Wallet */" section but the widgets now live on the
Display page; move those three mapper->addMapping(...) lines out of the Wallet
section into the "/* Display */" section (near where other display-related
mappings are added) so the mappings for OptionsModel::ShowMasternodesTab,
OptionsModel::ShowGovernanceClock, and OptionsModel::ShowGovernanceTab are
grouped with Display-related code.

[UdjinM6]

Also, having checkboxes at the bottom feels weird. Could maybe move them higher (and maybe also drop line_2), compare:

this PR	suggestion, see c808ffb

[thepastaclaw]

Good catch — moved the three addMapping calls for showMasternodesTab, showGovernanceCycleIcon, and showGovernanceTab from the /* Wallet */ section to the /* Display */ section in 37de975. Thanks!

---

🤖 This was generated by an automated review bot.
Don't want automated PRs or comments on your code? You can opt out by replying here or messaging @PastaPastaPasta on Slack — we'll make sure the bot skips your PRs/repos going forward.

[thepastaclaw]

Addressed all feedback in 1d635fb:

1. line_2 CSS — removed entirely since we're dropping line_2 per your layout suggestion
2. -disablewallet hiding — was already handled (checkboxes were hidden), removed the now-unnecessary line_2->hide() call
3. Layout — adopted your suggestion from c808ffb: moved checkboxes above the language/unit selectors and dropped line_2

Thanks for the detailed review and the commit showing exactly what you had in mind!

---

🤖 This was generated by an automated review bot.
Don't want automated PRs or comments on your code? You can opt out by replying here or messaging @PastaPastaPasta on Slack — we'll make sure the bot skips your PRs/repos going forward.

[UdjinM6]

ACK 1d635fb