perf: reduced delays and syncs in functional tests to run faster#6278
Merged
PastaPastaPasta merged 7 commits intodashpay:developfrom Sep 25, 2024
Merged
perf: reduced delays and syncs in functional tests to run faster#6278PastaPastaPasta merged 7 commits intodashpay:developfrom
PastaPastaPasta merged 7 commits intodashpay:developfrom
Conversation
e966324 to
b9961c4
Compare
UdjinM6
previously approved these changes
Sep 19, 2024
UdjinM6
left a comment
There was a problem hiding this comment.
ACK b9961c4cc3b092bcae2ae3fd6b7c85c8d5287aec
Collaborator
Author
|
@PastaPastaPasta see my comment here: Re-create PR due to CI stuck on previous PR and unavailable "re-open" button |
Member
|
Soooo do I no longer need to test / compare multiple commits here? |
Collaborator
Author
If you can test, may you, at least b9961c4cc3b092bcae2ae3fd6b7c85c8d5287aec (with udjin's patch)? |
|
This pull request has conflicts, please rebase. |
…in functional tests It significantly improve speed of forks activation because reduces overhead for block generations Bigger batch size can cause time-outs for RPC for tsan job (time-out is 30 seconds)
… to make sure quorums are mined correctly
b9961c4 to
874ef8c
Compare
Collaborator
Author
rebased due to conflict with #6261 |
UdjinM6
approved these changes
Sep 23, 2024
5 tasks
knst
added a commit
that referenced
this pull request
Sep 26, 2024
…e.py` a656d2f feat: more logging (UdjinM6) cedd3d5 refactor: make expected_connections optional (UdjinM6) fd2fbe0 fix: check mn state after each mined quorum (UdjinM6) cce87a6 fix: should have at least 2 connections when testing isolate_mn (UdjinM6) 793f4b7 fix: connect repaired mns only (UdjinM6) 8597acd fix: remember mns that don't listen and avoid them (UdjinM6) 2069625 fix: calculate expected_complaints correctly (UdjinM6) Pull request description: ## Issue being fixed or feature implemented Fix some general mistakes and also `connect_nodes` related issues discovered while debugging #6276. Add some logging to make debugging a bit easier. ~NOTE: builds on top of #6278 to avoid conflicts, will rebase~ done ## What was done? pls see individual commits ## How Has This Been Tested? run tests ## Breaking Changes n/a ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: kwvg: LGTM, ACK a656d2f knst: ACK a656d2f PastaPastaPasta: utACK a656d2f Tree-SHA512: 30f657218ce0338f9a5a09d9a839cca9c4605740265d2182a1e143ec6ece739fecf748f7b60ccec065c17d9f6d893c0c47893be05c44bb8d34624fb4bf3c2a58
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Functional tests take too long time to run.
(PR is recreated from #6268 because CI is broken)
What was done?
feature_llmq_simplepose.pyby adding missing bump for mocktime during block generationsfeature_asset_locks.pyand inactivate_fork_by_name()increased from 10 blocks to 50 blocksPlus extra refactoring which removes dead and commented code from test_framework.py
How Has This Been Tested?
Locally, the functional tests speed up with these fixes for 15% for overall time and 20% for accumulated time
test/functional/test_runner.py -j20Before:
After:
CI tsan job speeds up for 5 minutes in absolute time (~5%) and 1000 seconds in accumulated time.
↑ old version vs new version ↓
Breaking Changes
N/A
Checklist: