ci: adds flag -Werror=reorder for arm target#5540
Merged
UdjinM6 merged 2 commits intodashpay:developfrom Aug 22, 2023
Merged
Conversation
…ir order
It fixes this warning:
net_processing.cpp: In constructor ‘{anonymous}::PeerManagerImpl::PeerManagerImpl(const CChainParams&, CConnman&, CAddrMan&, BanMan*, CScheduler&, ChainstateManager&, CTxMemPool&, const std::unique_ptr<LLMQContext>&, bool)’:
net_processing.cpp:308:15: error: ‘{anonymous}::PeerManagerImpl::m_addrman’ will be initialized after [-Werror=reorder]
308 | CAddrMan& m_addrman;
| ^~~~~~~~~
net_processing.cpp:307:19: error: ‘BanMan* const {anonymous}::PeerManagerImpl::m_banman’ [-Werror=reorder]
307 | BanMan* const m_banman;
| ^~~~~~~~
net_processing.cpp:1547:1: error: when initialized here [-Werror=reorder]
1547 | PeerManagerImpl::PeerManagerImpl(const CChainParams& chainparams, CConnman& connman, CAddrMan& addrman, BanMan* banman,
| ^~~~~~~~~~~~~~~
PastaPastaPasta
approved these changes
Aug 21, 2023
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The order of members in a class/struct definition and the order of their initialization should match. This ensures that the code is more error-proof in cases where the order of member initializations is important, as they may depend on each other.
Instead manual checking of member initialization better let CI handle it.
Last PR where it's noticed: #5531 (comment)
What was done?
New flag "-Werror=reorder" for
configure.acand fixes existing code.How Has This Been Tested?
Build code with
--enable-werrorBreaking Changes
N/A
Checklist: