refactor: implement c++23 inspired ToUnderlying

[PastaPastaPasta]

Issue being fixed or feature implemented

Avoid lots of static_cast's from enums to underlying types. Communicate intention better

What was done?

implement c++23 inspired ToUnderlying, then see std::to_underlying and https://en.cppreference.com/w/cpp/types/underlying_type; Then, we use this instead of static_casts for enums -> underlying type

How Has This Been Tested?

make check

Breaking Changes

None

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

[PastaPastaPasta]

I'm really confused why this build fails... Please help 🙈

[UdjinM6]

I'm really confused why this build fails... Please help 🙈

git add src/util/underlying.h ;)

[PastaPastaPasta]

I'm really confused why this build fails... Please help 🙈

git add src/util/underlying.h ;)

Oh 🙈 I'll do that tonight 😂

[knst]

LGTM, but let's add these also and may be this

[UdjinM6]

linter complains

A new circular dependency in the form of "llmq/debug -> llmq/dkgsessionhandler -> llmq/debug" appears to have been introduced.
A new circular dependency in the form of "llmq/debug -> llmq/dkgsessionhandler -> llmq/dkgsession -> llmq/debug" appears to have been introduced.

[PastaPastaPasta]

linter complains

A new circular dependency in the form of "llmq/debug -> llmq/dkgsessionhandler -> llmq/debug" appears to have been introduced.
A new circular dependency in the form of "llmq/debug -> llmq/dkgsessionhandler -> llmq/dkgsession -> llmq/debug" appears to have been introduced.

resolved

[knst]

utACK

[UdjinM6]

LGTM, utACK