ci: convert semantic pr title check to use action#5071
Merged
PastaPastaPasta merged 6 commits intodashpay:developfrom Nov 7, 2022
Merged
ci: convert semantic pr title check to use action#5071PastaPastaPasta merged 6 commits intodashpay:developfrom
PastaPastaPasta merged 6 commits intodashpay:developfrom
Conversation
thephez
commented
Nov 3, 2022
| trivial | ||
| backport | ||
| # Configure which scopes are allowed (newline delimited). | ||
| scopes: | |
Collaborator
Author
There was a problem hiding this comment.
It's possible to eliminate the scopes section here. In that case it would check the types, but allow any scope. I don't think we want to do that, but it's an option 🤷♂️
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
PastaPastaPasta
approved these changes
Nov 7, 2022
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The previously used service https://github.com/zeke/semantic-pull-requests was deprecated by the time we actually updated the master branch. This converts to using a GitHub action to enforce conventional commit syntax for PR titles in alignment with our contributing guide.
Notes
pull_request_targetamannn/action-semantic-pull-request#182. As I understand it, this shouldn't introduce any issues.What was done?
Although the contributing guide indicated conventional commit syntax should be used for PR titles, nothing was enforcing it. This PR adds a GitHub Action (semantic-pull-request) that checks PR titles to make sure they match the relevant format and type/scope criteria.
How Has This Been Tested?
Tested using thephez#5 in my fork of this repo. See https://github.com/thephez/dash/actions/workflows/semantic-pull-request.yml for results of various attempts.
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only