Fix Dash build for Arch Linux with GCC 11.1#4398
Merged
UdjinM6 merged 1 commit intodashpay:developfrom Sep 18, 2021
Merged
Conversation
The SignatureHash() template function is declared in a header but defined in a .cpp file. That means only its instantiations are available from outside. For some reason, GCC 11.1 on Arch Linux doesn't see implicit instantiations for CTransaction and CMutableTransaction. Define these explicitly to make the compiler happy. Signed-off-by: Dzutte <dzutte.tomsk@gmail.com>
Collaborator
|
utACK |
PastaPastaPasta
approved these changes
Sep 17, 2021
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
Seems fine to me 🤷
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 9, 2023
The SignatureHash() template function is declared in a header but defined in a .cpp file. That means only its instantiations are available from outside. For some reason, GCC 11.1 on Arch Linux doesn't see implicit instantiations for CTransaction and CMutableTransaction. Define these explicitly to make the compiler happy. Signed-off-by: Dzutte <dzutte.tomsk@gmail.com>
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
The SignatureHash() template function is declared in a header but defined in a .cpp file. That means only its instantiations are available from outside. For some reason, GCC 11.1 on Arch Linux doesn't see implicit instantiations for CTransaction and CMutableTransaction. Define these explicitly to make the compiler happy. Signed-off-by: Dzutte <dzutte.tomsk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SignatureHash() template function is declared in a header but
defined in a .cpp file. That means only its instantiations are available
from outside.
For some reason, GCC 11.1 on Arch Linux doesn't see implicit
instantiations for CTransaction and CMutableTransaction.
Define these explicitly to make the compiler happy.
Signed-off-by: Dzutte dzutte.tomsk@gmail.com