Skip to content

build: gitian, linting and macOS-specific QoL improvements (part 1)#4255

Merged
PastaPastaPasta merged 9 commits intodashpay:developfrom
kwvg:darwinqol
Sep 1, 2021
Merged

build: gitian, linting and macOS-specific QoL improvements (part 1)#4255
PastaPastaPasta merged 9 commits intodashpay:developfrom
kwvg:darwinqol

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented Jul 15, 2021 •
edited
Loading

This is a prerequisite for C++17 support on macOS.

Contains patches UdjinM6@03d67bc ... UdjinM6@3f7d693

Part 1: #4255 (this pull request)
Part 2: #4378
Part 3: #4379

@kwvg kwvg mentioned this pull request Jul 15, 2021
Merged
@kwvg kwvg marked this pull request as draft July 15, 2021 18:01
@github-actions
Copy link

github-actions bot commented Jul 19, 2021

This pull request has conflicts, please rebase.

@UdjinM6 UdjinM6 mentioned this pull request Jul 19, 2021
Merged
@UdjinM6
Copy link

UdjinM6 commented Jul 19, 2021

Note: 5041 was already backported earlier. It was superseded by 12783 later that's why the code from 5041 is "missing".

@kwvg kwvg force-pushed the darwinqol branch 3 times, most recently from 782853c to 9f710e4 Compare July 20, 2021 16:30
@kwvg kwvg mentioned this pull request Aug 12, 2021
Merged
@kwvg kwvg force-pushed the darwinqol branch 11 times, most recently from bb0ae2d to b43da11 Compare August 24, 2021 17:07
@kwvg kwvg marked this pull request as ready for review August 24, 2021 17:10
PastaPastaPasta
PastaPastaPasta requested changes Aug 25, 2021
View reviewed changes
@kwvg kwvg force-pushed the darwinqol branch 2 times, most recently from 0a653a3 to 9f03ec9 Compare August 25, 2021 15:13
@kwvg kwvg requested a review from PastaPastaPasta August 25, 2021 18:46
This was referenced Aug 30, 2021
Merged
Merged
@kwvg kwvg changed the title build: gitian, linting and macOS-specific QoL improvements build: gitian, linting and macOS-specific QoL improvements (part 1) Aug 30, 2021
@kwvg kwvg force-pushed the darwinqol branch 2 times, most recently from 3567740 to 5a90948 Compare August 30, 2021 19:02
UdjinM6
UdjinM6 requested changes Aug 30, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see UdjinM6@5658aea + pls squash 17550 and 15236 pairs so that we would have 1 commit per backported PR

@UdjinM6
Copy link

UdjinM6 commented Aug 31, 2021

FYI: Adding PR 16392 (708cc7575d4d73f465304cd30ad0c4b46b266810 from #4378 + "more" UdjinM6@efa6796) fixes macos build in CI, see https://gitlab.com/UdjinM6/dash/-/pipelines/362805572

@kwvg kwvg requested a review from UdjinM6 September 1, 2021 06:48
@UdjinM6 UdjinM6 added this to the 18 milestone Sep 1, 2021
UdjinM6
UdjinM6 approved these changes Sep 1, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

utACK

@UdjinM6
Copy link

UdjinM6 commented Sep 1, 2021

ping @PastaPastaPasta

UdjinM6
UdjinM6 requested changes Sep 1, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed few minor issues + should rename 15236 to just "merge ..." now (not "force-merge ...") (thanks @PastaPastaPasta 👍 :) )

@kwvg kwvg requested a review from UdjinM6 September 1, 2021 20:25
UdjinM6
UdjinM6 approved these changes Sep 1, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

PastaPastaPasta
PastaPastaPasta approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@PastaPastaPasta PastaPastaPasta merged commit b483948 into dashpay:develop Sep 1, 2021
This was referenced Sep 2, 2021
Merged
Merged
@kwvg kwvg deleted the darwinqol branch July 18, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18

Development

Successfully merging this pull request may close these issues.

3 participants

@kwvg @UdjinM6 @PastaPastaPasta