net: Use Intra-Quorum Relay connections for other messages too#4021
Merged
UdjinM6 merged 2 commits intodashpay:developfrom Apr 3, 2021
Merged
net: Use Intra-Quorum Relay connections for other messages too#4021UdjinM6 merged 2 commits intodashpay:developfrom
UdjinM6 merged 2 commits intodashpay:developfrom
Conversation
xdustinface
requested changes
Mar 26, 2021
xdustinface
left a comment
There was a problem hiding this comment.
Makes sense 👍 Please let me know your thoughts about the two comments below, i thought quite some time about it now but it seems to be tricky with all those flags involved 🙈
Make intra-quorum data delivery more robust.
PastaPastaPasta
approved these changes
Mar 29, 2021
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK, would be nice if there were tests around this
Collaborator
|
@PastaPastaPasta Sometimes I think you're using a template response message for PRs 😄
|
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 17, 2022
…ay#4021) * net: Use Intra-Quorum Relay connections for other messages too Make intra-quorum data delivery more robust. * Apply review suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make intra-quorum data delivery more robust.
We stopped relaying this data (#3368) when we were preparing to implement Concentrated Recovery (#3389) one part of which was spork21 ("all connected" mode) (#3380) because relaying all the data via 50+ connections from each member to everyone else in the quorum at once could be wasteful potentially. But I think it should still be fine for quorum masternodes to re-use a small subset (in case of "all connected" mode) of intra-quorum connections to relay the data inside quorums. Syncing via these connections should also be safe (unlike syncing via potentially short-living pure "masternode" connections). Not having to rely on non-maliciousness of (regular) nodes surrounding each quorum member is yet another good thing imo.
Thoughts?
Based on #4020 atm.