Skip to content

Fix a couple of issues with -rescan#3828

Merged
UdjinM6 merged 6 commits intodashpay:developfrom
UdjinM6:fix_rescan
Nov 27, 2020
Merged

Fix a couple of issues with -rescan#3828
UdjinM6 merged 6 commits intodashpay:developfrom
UdjinM6:fix_rescan

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Nov 26, 2020

Revival of #3796

@UdjinM6 UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Nov 26, 2020
@UdjinM6 UdjinM6 added this to the 17 milestone Nov 26, 2020
Copy link

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(re-)utACK

@UdjinM6
Copy link
Author

UdjinM6 commented Nov 27, 2020

It's been more than a week with no change requests or any issues raised on #3796 and this one is identical, merging.

@UdjinM6 UdjinM6 merged commit 3b48c96 into dashpay:develop Nov 27, 2020
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-utACK

@UdjinM6 UdjinM6 deleted the fix_rescan branch July 1, 2021 21:45
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 15, 2022
* Update key metadata when we find a key which appears to be used earlier than we expected

* Introduce second mode for `-rescan` to be able to rescan from genesis block

* Add `-rescan=2` option to Repair tab

* Expose `nTimeFirstKey` in `CreateWalletFromFile` logs and in `getwalletinfo` rpc

* fix: check `pIndex != nullptr`

* Ignore incorrect -rescan values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants