Fix flushing of rejects before disconnecting#3429
Merged
codablock merged 3 commits intodashpay:developfrom Apr 17, 2020
Merged
Conversation
UdjinM6
reviewed
Apr 17, 2020
This was only used in only one remaining place and only to ensure that reject messages are sent before closing sockets. This is solved by the previous commit now.
ded6168 to
d8bbdee
Compare
Author
|
It looks like this fix won't be enough to reliably flush send (rejects) buffers. I read into how socket |
fbe1fcb to
08b57c1
Compare
PastaPastaPasta
approved these changes
Apr 17, 2020
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK, some diffs scare me when it comes to backports, but its fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.
This is currently based on #3421. I'll rebase after it got merged.