Replace vecAskFor with a priority queue#3147
Merged
UdjinM6 merged 1 commit intodashpay:developfrom Oct 16, 2019
Merged
Conversation
This avoids sorting before looping through it to figure out what to request. The assumption that sorting would be cheap when vecAskFor is already mostly sorted (only unsorted at the end) turned out to be false. In reality, ~50% of CPU time was consumed by the sort when a lot of traffic (thousands of TXs) happen.
UdjinM6
approved these changes
Oct 14, 2019
UdjinM6
left a comment
There was a problem hiding this comment.
utACK
nit: time to rename MAPASKFOR_MAX_SZ? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids sorting before looping through it to figure out what to
request. The assumption that sorting would be cheap when vecAskFor is
already mostly sorted (only unsorted at the end) turned out to be false.
In reality, ~50% of CPU time was consumed by the sort when a lot of traffic
(thousands of TXs) happen.