Few fixes for wait_for_instantlock#3123
Merged
UdjinM6 merged 2 commits intodashpay:developfrom Oct 1, 2019
Merged
Conversation
|
Needs rebase. EDIT: #3124 is merged as well now. |
…red, use `wait_until` Currently it simply returns False if islock failed but that's not the way we use it (we never check results).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pls see individual commits for details.
Note:
p2p-instantsend.pyis expected to fail randomly now because of propagation issues which were not caught previously (should be fixed via #3124).Note2: Also needs #3122 to be merged first to importincluded similar changes herewait_until, will rebase