Implement isolate_node/reconnect_isolated_node in tests#2901
Merged
UdjinM6 merged 1 commit intodashpay:developfrom May 6, 2019
Merged
Implement isolate_node/reconnect_isolated_node in tests#2901UdjinM6 merged 1 commit intodashpay:developfrom
isolate_node/reconnect_isolated_node in tests#2901UdjinM6 merged 1 commit intodashpay:developfrom
Conversation
|
merged #2898, so this can be rebased |
97d1a0a to
609cc14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like Travis is too slow and peers are disconnected after
setnetworkactive(True)and the following connect attempt which drops the freshly established connection (and tests fail). To fix this we should confirm that peers were actually disconnected on an isolated node (getconnectioncountrpc should return 0) before proceeding further.Note: this PR includes #2898 , will rebase once it is merged (I decided not to request changes in the original PR because this patch also fixes similar potential issues with
llmq-chainlocks.py)