Better handle removing of fully confirmed IS locks#2836
Merged
codablock merged 5 commits intodashpay:developfrom Apr 5, 2019
Merged
Better handle removing of fully confirmed IS locks#2836codablock merged 5 commits intodashpay:developfrom
codablock merged 5 commits intodashpay:developfrom
Conversation
…d locks Also move the actual logic into HandleFullyConfirmedBlock and call it from NotifyChainLock and UpdatedBlockTip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes CInstantSendManager track in which block an IS locked transaction was mined and then uses this information to find IS locks to remove when blocks get sufficiently confirmed (via ChainLocks or 6 confs if CL is disabled).
This solves 2 issues:
This PR also fixes an issue with wallet transactions not being properly updated when IS locks were removed.
Testing this PR is a bit harder atm as the current
developbranch disconnects most 0.14 nodes due to invalid IS locks. This is due to the changes/fixes found in #2833. To test this PR, you'll have to locally revert #2833:git revert -m1 20ec1de4c68392a51b7f4b51e0617e89df87a539