Prepare Dash-related stuff before starting ThreadImport#2800
Merged
UdjinM6 merged 2 commits intodashpay:developfrom Mar 25, 2019
Merged
Prepare Dash-related stuff before starting ThreadImport#2800UdjinM6 merged 2 commits intodashpay:developfrom
UdjinM6 merged 2 commits intodashpay:developfrom
Conversation
…is active and we are running in masternode mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need
activeMasternodeManagerto be non-nullptrinThreadImport(which can happen atm if main thread is too slow) when running in masternode mode. OtherwiseactiveMasternodeManager->Init()inloadblkthread will not run which means we won't sendmnauthto other nodes (becauseactiveMasternodeInfo.proTxHash.IsNull() == true) i.e. they won't recognise us as a MN and won't send contributions etc. which in its turn causes tests to fail.Other Dash-related stuff seems to be not affected by the order of these things but it's probably better to keep them all together.