Remove all legacy/compatibility MN code#2600
Merged
UdjinM6 merged 37 commits intodashpay:developfrom Jan 3, 2019
Merged
Conversation
There are still places where these are used in the code. The next commits will clean these up.
Also replace all uses of IsMasternodeListSynced and IsWinnersListSynced with IsBlockchainSynced.
This is not valid in DIP3 mode
…EL_PING_MAX_SECONDS
…kTxOuts ...and let it crash instead. We expect this method to be called with the correct height now (after DIP3 was fully deployed).
Only masternodes sign governance objects, so there is no need for ECDSA support here anymore.
UdjinM6
reviewed
Jan 2, 2019
Also delete guide-startmany.md and masternode_conf.md
… miner tests This test is crashing otherwise in GetBlockTxOuts as it tries to access a previous block that is not existing.
Even though DIP3 was active on BIP9 level, the spork was not active yet at that point meaning that payments were not enforced at that time.
3e2bcef to
25d9dcb
Compare
|
Looks good, will compile and test a bit. |
Author
|
Also added df984f7, after the discussion we had. Turned out that the whole if/else block got unnecessary now. |
…nValid returns false IsTransactionValid already handles the case where IsDIP3Active() returns false, making it return true.
UdjinM6
reviewed
Jan 2, 2019
UdjinM6
left a comment
There was a problem hiding this comment.
Synced from scratch and reindexed with all files in place with no issues. Mixing/IS-ing seems to be working (client-side). Noticed just one small issue while compiling, see suggestions.
|
Actually, one more thing :) should drop |
33c0f32 to
392d119
Compare
Author
|
Forgot to mention: pushed the last 2 changes requested. Github had issues at that time, so notifications might not be sent out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code removed by this PR is unused already (after #2594 was merged), making it safe to remove all of it.
The next PR will refactor the remains of CMasternodeMan into CMasternodeMetaMan.