Skip to content

Remove duplicated check from CWallet::AvailableCoins#2336

Merged
UdjinM6 merged 1 commit intodashpay:developfrom
Duality-CDOO:patch-5
Oct 11, 2018
Merged

Remove duplicated check from CWallet::AvailableCoins#2336
UdjinM6 merged 1 commit intodashpay:developfrom
Duality-CDOO:patch-5

Conversation

@Duality-CDOO
Copy link

@Duality-CDOO Duality-CDOO commented Oct 5, 2018

  // We should not consider coins which aren't at least in our mempool
  // It's possible for these to be conflicted via ancestors which we may never be able to detect
  if (nDepth == 0 && !pcoin->InMempool())
      continue;

@Duality-CDOO Duality-CDOO changed the title Remove duplicated check Remove duplicated check CWallet::AvailableCoins Oct 5, 2018
@Duality-CDOO Duality-CDOO changed the title Remove duplicated check CWallet::AvailableCoins Remove duplicated check from CWallet::AvailableCoins Oct 5, 2018
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Good catch. Looks like we backported bitcoin#7715 from Bitcoin in f933c67 which was already applied in f4e4dd6

@UdjinM6 UdjinM6 added this to the 12.4 milestone Oct 5, 2018
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

utACK

@UdjinM6 UdjinM6 merged commit bed1ded into dashpay:develop Oct 11, 2018
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants