Don't use boost range adaptors in CDeterministicMNList

[codablock]

These cause crashes when used in for loops. Reason is very likely that
temporary CDeterministicMNList objects are destroyed before entering the
loop while the adaptors rely on these objects.

Discovered in one of our devnets while calling "protx list"

[UdjinM6]

Nice! The less dependencies the better :)

See inline comments.

Side note: conceptually, it's a bit concerning that we have to loop to build the vector only to pass this vector to some function to loop over it again. Sounds like a good place for some refactoring in the future (but I'm fine with this PR as a drop-in replacement for boost stuff for now).

[UdjinM6]

const auto& ...

[UdjinM6]

same

[UdjinM6]

same or even

-    for (auto txout : block.vtx[0]->vout) {
-        for (auto& dmn : dmnList.GetValidMNs()) {
+    for (const auto& txout : block.vtx[0]->vout) {
+        for (const auto& dmn : dmnList.GetValidMNs()) {

while at it ;)

[UdjinM6]

shouldn't we check for if (IsMNValid(p.second)) here?

[codablock]

Oh, good you spotted this one

[codablock]

Agree that this solution is suboptimal, and while reading your concern I realized that this is maybe a good candidate for something like ForEachMN(function). Will implement this now and push in a few minutes.

[codablock]

Pushed new version of this fix, based on ForEachMN which avoids unnecessary copies

[UdjinM6]

Nice! 👍

utACK