RPC: fix wallet lock check in privatesend start#2102
Merged
UdjinM6 merged 1 commit intodashpay:developfrom Jun 11, 2018
Merged
Conversation
thephez
approved these changes
Jun 8, 2018
Collaborator
thephez
left a comment
There was a problem hiding this comment.
tACK 👍
> walletpassphrase "pass" 600 true
> privatesend start
Mixing started successfully
Yoyae
pushed a commit
to monacocoin-net/monoeci-core
that referenced
this pull request
Jun 12, 2018
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Mar 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fail only if locked completely, see https://github.com/dashpay/dash/blob/master/src/wallet/crypter.h#L158-L165 for more info about
IsLocked()logic.Steps to reproduce the issue:
Kudos to @thephez for finding the issue 👍