Merged
Conversation
codablock
reviewed
Jun 5, 2018
| @@ -24,7 +24,7 @@ static const int MNPAYMENTS_SIGNATURES_TOTAL = 10; | |||
| // V1 - Last protocol version before update | |||
| // V2 - Newest protocol version | |||
| static const int MIN_MASTERNODE_PAYMENT_PROTO_VERSION_1 = 70206; | |||
There was a problem hiding this comment.
shouldn't this also be bumped to 70208?
Author
There was a problem hiding this comment.
Yes, that's how we did this in the past and why it says V1 - Last protocol version before update BUT I was thinking about it a bit more and it seems to me that we probably should NOT bump this in the time of major migration to have the same base with old nodes when spork10 is off and instead we should bump it in a minor pre-major update (if at all, maybe we could just leave it static forever?).
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
* bump MIN_GOVERNANCE_PEER_PROTO_VERSION * bump MIN_MASTERNODE_PAYMENT_PROTO_VERSION_2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.