swap out old logo for T&C logo in Qt GUI#2081
Conversation
UdjinM6
left a comment
There was a problem hiding this comment.
See inline comments + toolbar.png and toolbar_testnet.png should be updated too.
src/qt/res/css/light.css
Outdated
|
|
||
| QLabel { /* Base Text Size & Color */ | ||
| font-size:12px; | ||
| font-size:9pt; |
There was a problem hiding this comment.
Should not touch this file, pls revert all changes made below.
src/qt/res/css/light-hires.css
Outdated
| @@ -1,5 +1,5 @@ | |||
| WalletFrame { | |||
| border-image: url(':/images/light/drkblue_walletFrame_bg') 0 0 0 0 stretch stretch; | |||
| border-image: url(':/images/light-retro/drkblue_walletFrame_bg') 0 0 0 0 stretch stretch; | |||
There was a problem hiding this comment.
Should not update this file, should copy light-hires theme to light-hires-retro and update it with -retro suffixes instead. Pls revert all changes made below.
There was a problem hiding this comment.
@UdjinM6 Previous to this PR, the light-hires.css file actually makes reference to light theme. Since we re-named light to light-retro, I believe the references in light-hires.css should be updated to refer to the new name, right?
In that case I believe this should stand. Otherwise light-hires.css is referencing the new, updated images.
There was a problem hiding this comment.
Hmm, no... Let me explain how I see it should be done, step by step:
light-hiresshould be copied tolight-hires-retro;light-hires-retroshould have all links updated fromlighttolight-retro, should have no other code changes;light-hiresshould have all images updated to ones with the new logo, should have no code changes at all.
Will do, but wanted to note that those 2 image files aren't referenced or used anywhere I could see and planned to drop them in a later PR. |
|
re |
Note that this isn't a full re-design, but a simple logo swap. Special thanks to @dashchris for working on these images.
The first commit re-names the original "light" theme to "light-retro", the 2nd commit adds a new "light" theme with the new logo images.