12.3 release notes draft by UdjinM6 · Pull Request #2045 · dashpay/dash

UdjinM6 · 2018-04-22T14:53:01Z

Changes:

archive 0.12.2.3 release notes;
sketch out 12.3 release notes draft highlighting the most notable Dash-specific changes;
list backports in a separate file and link to it from the main one (because the list is waaaaay too huge this time due to no-squash merges).

This is a WIP and there are still quite a few TODOs. Probably should highlight few most notable backported changes like compact blocks, nulldummy softwork etc. I'm open for suggestions :)

troydash · 2018-04-24T01:34:16Z

doc/release-notes.md

+--------------------------------------------
+
+We backported many performance improvements from Bitcoin Core and aligned most of our codebase with version 0.14.
+Most notable ones besides various performance and stability imrovements probably are


improvements*

codablock

Proposing a few changes:
codablock@d79c9c0
codablock@2b99c7e

codablock · 2018-04-24T04:01:49Z

doc/release-notes.md

+------------------------
+
+PrivateSend collateral is no longer required to be N times of the PrivateSend fee, instead any input
+which is in the [1..N] range can be used as a collateral. Inputs that are in the [1..2) range will now


"Inputs that are in the [1..2) range will" is a bit unclear to me

thephez · 2018-04-24T14:06:13Z

doc/release-notes.md

+in terms of security and validation - it relies a lot on surrounding nodes, so please keep this in mind if you decide to
+use it for something.
+
+RPC changes


Not sure how comprehensive this is intended to be. Some other RPC items:

getrawmempool's added InstantSend-related info

getgovernanceinfo changed from mnwatchdog->sentinelping

getgenerate/setgenerate removed

getaddednodeinfo - dummy parameter removed

getwalletinfo - add PS balance

- `getgenerate`/`setgenerate` removed - `getaddednodeinfo` - dummy parameter removed

These two were changed via backports I believe, so shouldn't be in that list imo, but I'll add the rest of the list. Thanks! 👍

thephez

Couple typos

thephez · 2018-04-24T14:34:50Z

doc/release-notes.md

+Also, the devnet name is put into the sub-version of the `VERSION` message.
+If a node connects to the wrong network, it will immediately be disconnected.
+
+New format of network messsage signatures


Extra "s" in message

thephez · 2018-04-24T14:35:11Z

doc/release-notes.md

+PrivateSend collateral is no longer required to be N times of the PrivateSend fee, instead any input
+which is in the [1..N] range can be used as a collateral. Inputs that are in the [1..2) range will now
+be used in collaterals with OP_RETURN outputs which will allow such inputs to be completely consumed
+(previousely they were not used at all and instead were kept in wallet and global UTXO forever).


previousely -> previously

UdjinM6 · 2018-04-24T19:35:42Z

Applied suggested changes, rephrased few confusing parts, updated commit list.

troydash · 2018-04-24T21:11:20Z

doc/release-notes.md

+equal 1 PSF but strictly less than 2 PSF will be used in collaterals with OP_RETURN outputs. Note that such
+inputs will be consumed copletely, with no change outputs at all. This should lower number of inputs wallet
+would need to take care of, improve privacy by eleminating the case where user accidentally merge small
+non-private inputs together and also decrease global UTXO set size.


typo -- completely* eliminating*

troydash · 2018-04-24T21:12:41Z

doc/release-notes.md

+If you rely on the old output format, you can still specify an additional parameter for backwards compatibility (`all` for `count` and `status` for `list`).
+- `masternodelist` has a few new modes: `daemon`, `json`, `sentinel`
+- `debug` rpc now requires categories to be separated via `+`, not `,` like before (e.g. `dash+net`)
+- `getchaintips` now shows the block fork occured in `forkpoint` field


troydash · 2018-04-24T21:14:57Z

doc/release-notes.md

+- [`271c249e1`](https://github.com/dashpay/dash/commit/271c249e1) Skip next mn payments winners when selecting a MN to mix on (#1921)
+- [`ca89c7b87`](https://github.com/dashpay/dash/commit/ca89c7b87) [Trivial] Update PrivateSend denominations in comments / typo fixes (#1910)
+- [`b1817dd93`](https://github.com/dashpay/dash/commit/b1817dd93) Introduce CDarksendAccept class (for DSACCEPT messages) (#1875)
+- [`d69ad9d61`](https://github.com/dashpay/dash/commit/d69ad9d61) Skip existing masternode conections on mixing (#1833)


connections*

troydash · 2018-04-24T21:16:53Z

doc/release-notes.md

+- [`5b1c4d8a1`](https://github.com/dashpay/dash/commit/5b1c4d8a1) Few (mostly trivial) cleanups and fixes (#1940)
+- [`99273f63a`](https://github.com/dashpay/dash/commit/99273f63a) Use SPORK_6_NEW_SIGS to switch from signing string messages to hashes (#1937)
+- [`c65613350`](https://github.com/dashpay/dash/commit/c65613350) Switch masternode id in Dash data structures from CTxIn to COutPoint (#1933)
+- [`2ea6f7d82`](https://github.com/dashpay/dash/commit/2ea6f7d82) Use `override` keyword for overriden class member functions (#1644)


overridden*

UdjinM6 · 2018-04-25T11:25:08Z

@troydash Fixed typos in text, thanks! Won't fix typos in commit list however because they are buried in git history and they are presented here "as is", so pls just ignore them.

UdjinM6 · 2018-05-30T13:18:39Z

Should include all changes up to planned rc1 now, pls review.

codablock

utACK

nmarley · 2018-05-30T13:32:06Z

@UdjinM6 Any chance we can get UdjinM6#2 merged in? Would love if Chris can get credit for the Qt graphics work.

12.3 release notes draft

a58becf

UdjinM6 added this to the 12.3 milestone Apr 22, 2018

UdjinM6 added 2 commits April 23, 2018 23:48

update

2c1ab05

mn info dialog

bbf73f7

troydash reviewed Apr 24, 2018

View reviewed changes

typo

4eefa65

codablock reviewed Apr 24, 2018

View reviewed changes

thephez reviewed Apr 24, 2018

View reviewed changes

codablock and others added 4 commits April 24, 2018 21:44

Minor additions and fixes

636d916

A few additions

851a51b

Addressed reviews, rephrased, updated

ee2b726

add recent commits

7f1978f

troydash reviewed Apr 24, 2018

View reviewed changes

more typos

2561ef4

UdjinM6 added 2 commits April 30, 2018 01:15

add recent commits

369414a

Add recent commits

01198ec

UdjinM6 changed the title ~~[WIP] 12.3 release notes draft~~ 12.3 release notes draft May 30, 2018

codablock approved these changes May 30, 2018

View reviewed changes

add Chris Adam to credits for image work

988a02b

UdjinM6 mentioned this pull request May 30, 2018

add Chris (designer) to credits for image work UdjinM6/dash#2

Closed

UdjinM6 merged commit ca2eae6 into dashpay:develop May 30, 2018

UdjinM6 deleted the releasenotes123draft branch November 26, 2020 13:28

Conversation

UdjinM6 commented Apr 22, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codablock left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thephez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

UdjinM6 commented Apr 24, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

UdjinM6 commented Apr 25, 2018

Uh oh!

UdjinM6 commented May 30, 2018

Uh oh!

codablock left a comment

Choose a reason for hiding this comment

Uh oh!

nmarley commented May 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants