[ZMQ] append a message sequence number to every ZMQ notification#1082
Merged
UdjinM6 merged 3 commits intodashpay:v0.12.1.xfrom Oct 17, 2016
chaeplin:v0.12.1.x
Merged
[ZMQ] append a message sequence number to every ZMQ notification#1082UdjinM6 merged 3 commits intodashpay:v0.12.1.xfrom chaeplin:v0.12.1.x
UdjinM6 merged 3 commits intodashpay:v0.12.1.xfrom
chaeplin:v0.12.1.x
Conversation
* Fixes ZMQ startup with bad arguments. pr 7621 * [ZMQ] append a message sequence number to every ZMQ notification - pr 7762 - contrib/zmq/zmq_sub.py to python 3 compatible
Author
|
travis-ci not passed |
|
Yeah, this still happens sometimes for 32bit build. Failed at "-salvagewallet" this time which shouldn't be affected by changes here so I restarted the job. Feel free to reopen this if it passes. |
|
Yeah, don't get dragged down by Travis - sometimes it just has a bad day :-) |
MMSG_RAWTXLOCK to MSG_RAWTXLOCK
UdjinM6
approved these changes
Oct 17, 2016
UdjinM6
left a comment
There was a problem hiding this comment.
Slight dashification needed in docs, otherwise utACK
doc/zmq.md
Outdated
|
|
||
| There are several possibilities that ZMQ notification can get lost | ||
| during transmission depending on the communication type your are | ||
| using. Bitcoind appends an up-counting sequence number to each |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 9, 2022
…vent messages, reverse LogPrintLevel order c4e7717 refactor: Change LogPrintLevel order to category, severity (laanwj) ce92071 leveldb: Log messages from leveldb with category and debug level (laanwj) 18ec120 http: Use severity-based logging for messages from libevent (laanwj) bd971bf logging: Unconditionally log levels >= WARN (laanwj) Pull request description: Log messages from leveldb and libevent libraries in the severity+level based log format introduced in bitcoin#24464. Example of messages before: ``` 2022-05-24T18:11:57Z [libevent] libevent: event_add: event: 0x55da963fcc10 (fd 10), EV_READ call 0x7f1c7a254620 2022-05-24T18:11:57Z [libevent] libevent: Epoll ADD(1) on fd 10 okay. Old events were 0; read change was 1 (add); write change was 0 (none); close change was 0 (none) 2022-05-24T18:12:08Z leveldb: Generated table #609127@1: 6445 keys, 312916 bytes 2022-05-24T18:12:08Z leveldb: Generated table #609128@1: 5607 keys, 268548 bytes 2022-05-24T18:12:08Z leveldb: Generated table #609129@1: 189 keys, 9384 bytes 2022-05-24T18:12:08Z leveldb: Generated table #609130@1: 293 keys, 13818 bytes ``` Example of messages after: ``` 2022-05-24T17:59:52Z [libevent:debug] event_add: event: 0x5652f44dac10 (fd 10), EV_READ call 0x7f210f2e6620 2022-05-24T17:59:52Z [libevent:debug] Epoll ADD(1) on fd 10 okay. Old events were 0; read change was 1 (add); write change was 0 (none); close change was 0 (none) 2022-05-24T17:59:53Z [leveldb:debug] Recovering log dashpay#1072 2022-05-24T17:59:53Z [leveldb:debug] Level-0 table dashpay#1082: started 2022-05-24T17:59:53Z [leveldb:debug] Level-0 table dashpay#1082: 193 bytes OK 2022-05-24T17:59:53Z [leveldb:debug] Delete type=3 dashpay#1070 2022-05-24T17:59:53Z [leveldb:debug] Delete type=0 dashpay#1072 ``` The first commit changes it so that messages with level Warning and Error are always logged independent of the `-debug` setting. I think this is useful to make sure warnings and errors, which tend to be important, are not lost. In the future this should be made more configurable. Last commit changes LogPrintLevel argument order to category, severity: This is more consistent with the other functions, as well as with the logging output itself. If we want to make this change, we should do it before it's all over the place. ACKs for top commit: jonatack: Tested ACK c4e7717 Tree-SHA512: ea48a1517f8c1b23760e59933bbd64ebf09c32eb947e31b8c2696b4630ac1f4303b126720183e2de052bcede3a17e475bbf3fbb6378a12b0fa8f3582d610930d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code from bitcoin main branch.
contrib/zmq/zmq_sub.py to python 3 compatible
tested / sample log https://gist.github.com/chaeplin/cdeb14a8a5fcc7974109af30696224d0