[1.15] cherrypick grpc keepalives (#1382)#1383
Conversation
* chore: Add grpc keepalives Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Make grpc keepalive configurable Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Fix review comments Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Missing keepalive config for GRPC TLS INSECURE Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Add test Signed-off-by: Javier Aliaga <javier@diagrid.io> * fix: Comment typo Signed-off-by: Javier Aliaga <javier@diagrid.io> --------- Signed-off-by: Javier Aliaga <javier@diagrid.io>
There was a problem hiding this comment.
@cicoyle as far as I understand this is a cherry pick, however the Java properties are a little bit inconsistent with other Java property names.
Here we are using a mix of dot notation and camel case, while for other GRPC properties we use dot notation like:
dapr.grpc.tls.insecuredapr.grpc.tls.ca.path
Ideally we should have something like:
dapr.grpc.keepalive.enableddapr.grpc.keepalive.time.secondsdapr.grpc.keepalive.timeout.seconds- etc
This way we have a nice name spacing approach to properties.
We should try to be consistent, it helps with documentation and long term maintenance.
CC: @javier-aliaga
I'll open follow up PRs to address the inconsistency there, good catch 👍🏻 since you approved this, Ill proceed with this since its a cherrypick then open 2 followup PRs to fix it and add docs👍🏻 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #1383 +/- ##
===============================================
Coverage ? 77.58%
Complexity ? 1777
===============================================
Files ? 205
Lines ? 5474
Branches ? 600
===============================================
Hits ? 4247
Misses ? 907
Partials ? 320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* chore: Add grpc keepalives * chore: Make grpc keepalive configurable * chore: Fix review comments * chore: Missing keepalive config for GRPC TLS INSECURE * chore: Add test * fix: Comment typo --------- Signed-off-by: Javier Aliaga <javier@diagrid.io> Co-authored-by: Javier Aliaga <javier@diagrid.io> Signed-off-by: siri-varma <siri.varma@outlook.com>
* chore: Add grpc keepalives * chore: Make grpc keepalive configurable * chore: Fix review comments * chore: Missing keepalive config for GRPC TLS INSECURE * chore: Add test * fix: Comment typo --------- Signed-off-by: Javier Aliaga <javier@diagrid.io> Co-authored-by: Javier Aliaga <javier@diagrid.io> Signed-off-by: siri-varma <siri.varma@outlook.com>
cherrypick this PR