CreateTimerChain was comparing the same timestamp for future validation#41
Merged
CreateTimerChain was comparing the same timestamp for future validation#41
Conversation
famarting
reviewed
Aug 21, 2025
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Collaborator
Author
|
@dapr/approvers-java-sdk and @dapr/maintainers-java-sdk please review and merge, as we will need a new release with this patch. |
famarting
approved these changes
Aug 22, 2025
Collaborator
Author
|
@javier-aliaga this fix also allowed me to add back the @disabled test for longTimers(). |
javier-aliaga
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
The TaskOrchestrationExecutor was comparing two timestamps, expecting one to be in the future, in such case it created another timer task. The problem arise when both timestamps are the same and the comparison returns 0. Instead of returning without creating a new timer, it was creating a new timer, causing multiple timers that were not needed.
resolves #1511
Pull request checklist
CHANGELOG.mdAdditional information